commit | cf4f901fdf348a7bd4eb8d03fea9c79d2307f8f3 | [log] [tgz] |
---|---|---|
author | Laurent <lalmeras@gmail.com> | Fri Dec 01 12:36:07 2023 +0100 |
committer | GitHub <noreply@github.com> | Fri Dec 01 06:36:07 2023 -0500 |
tree | 1a9135d42e4eb7dd35a6b1df699510e406dc5f8c | |
parent | bfbcc299bca9efdac694e98cc3f964416669b69f [diff] |
[MSHARED-1285] - refactor IncrementalResourceFilteringTest (#82) Existing test uses a TestIncrementalBuildContext from plexus-build-api:tests that is buggy. isUptodate and hasDelta methods return wrong result, due to path resolution issues (wrong basedir, leading/trailing slashes). It seems it was not an issue for previous implementation as only the scanners were invoked by tests, and they provide the expected result. Future code changes need a better mock (and customizable, project bound) to allow now behaviour that invokes isUpdtodate or hasDelta methods. plexus-build-api:tests dependency is removed.
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MSHARED-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.