commit | fa80028166ffde859b1a1e20547701a9bed34d54 | [log] [tgz] |
---|---|---|
author | Daniel Widdis <widdis@gmail.com> | Tue Feb 22 00:48:04 2022 -0600 |
committer | GitHub <noreply@github.com> | Tue Feb 22 16:48:04 2022 +1000 |
tree | b75838a140ed67e83f8aaacafc824f765e34a960 | |
parent | f605c0f52f20bf80c7473ec642474ba4fc028d4c [diff] |
[MCOMPILER-485] Fixes internal string format in generated package-info.class (#95) * [MCOMPILER-485] Add failing integration test for class file contents The internal package string in the class file should contain a forward slash * [MCOMPILER-485] Always use forward slash for internal package name Per JLS 4.2.1 if the file separator character is not a forward slash, replace it * [MCOMPILER-485] Call ClassWriter#visit before ClassWriter#visitSource Javadocs for org.objectweb.asm.ClassVisitor specify "The methods of this class must be called in the following order: visit [ visitSource ] ..."
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MCOMPILER-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.