commit | e64fd3b3ef93fc8831403cb9ca0147033bae12d6 | [log] [tgz] |
---|---|---|
author | Russell Howe <rhowe@siksai.co.uk> | Sat Sep 04 11:03:21 2021 +0200 |
committer | rfscholte <rfscholte@apache.org> | Sat Sep 04 11:03:21 2021 +0200 |
tree | 17deb44beac6cd4f0322fe7f317ccf4c30714ab1 | |
parent | e00a681836cd9befe23ff16f477617febcb2c2f2 [diff] |
[MCOMPILER-398] Simplify the implementation of the inclusion/exclusion logic The 'getSourceInclusionScanner' method can be simplified quite considerably. In the case where there are no includes or excludes, we can simply reuse the empty set of excludes we have rather than pulling an empty set out of Collections. This then makes both constructor calls to SimpleSourceInclusionScanner the same, so they can be merged. For the case where there are no includes, there are two paths. When there are also no excludes, we construct a singleton set of the default include pattern and assign it to includes. In the other case, where we have excludes but no includes, we add the defaultIncludePattern to the empty set of includes we have. These are equivalent operations, so merge them as well. i.e. have some default includes but allow this to be overridden and also allow excludes to be specified. Signed-off-by: rfscholte <rfscholte@apache.org>
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MCOMPILER-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.