commit | de614e3ce5f4b4b7fc12e6cbd54189638e58a551 | [log] [tgz] |
---|---|---|
author | Jeremy Landis <jeremylandis@hotmail.com> | Mon Jan 20 19:35:03 2020 -0500 |
committer | Enrico Olivelli <eolivelli@apache.org> | Thu Feb 06 14:34:17 2020 +0100 |
tree | cc5b59e1115994aea82eab6bf374b84fa0094c80 | |
parent | c427a30030649947c0780d81517a30f188760541 [diff] |
[MCHECKSTYLE-389] Partial revert of MCHECKSTYLE-365 severity change back to 'null' default The severity setting even on original logic is incorrect. It must remain null if it is to work properly at all. While counts in fact are off, the entire section will be lost if it doesn't contain issues in at least 'error' due to the change when using default configurations. This has to be reverted as not originally fixed properly so that the rules aggregate will display. Example case has no 'error' type, only 'warning'. Changing this to 'warning' will pick that section up. Using 'info' or 'error' fails to do so. I didn't bother with checking 'ignore' as that most likely is not good use either. There is definitely a bug here as originally designed and more care needs taken to fix properly.
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[MCHECKSTYLE-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.