commit | 6123dfb362afc1ada08c6e658a13aa25772d88d0 | [log] [tgz] |
---|---|---|
author | Tamas Cservenak <tamas@cservenak.net> | Tue May 16 11:54:08 2023 +0200 |
committer | Tamas Cservenak <tamas@cservenak.net> | Tue May 16 11:54:08 2023 +0200 |
tree | ce4c1c57705d2b3c944a56a6934263f0d39820e5 | |
parent | 967f1c3e50a435703037f9957be3c94e9d432546 [diff] |
[ARCHETYPE-637] Fix PomUtils pretty-print issue on Java 9+ As of Java 9, the Transformer class's pretty-print feature doesn't define the actual format. Therefore, whitespace-only nodes will be outputted as well. This has been discussed in this [JDK bug ticket](https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list). Also, [Java 9's release note](https://www.oracle.com/java/technologies/javase/9-notes.html) has explained this in the xml/jaxp section. If we want our pretty-print method to always generate the same format under various Java versions, we need to provide a stylesheet file. ref: https://bugs.openjdk.java.net/browse/JDK-8262285?attachmentViewMode=list https://www.baeldung.com/java-pretty-print-xml#pretty-printing-xml-with-the-transformer-class Co-authored-by: Moderne <team@moderne.io> --- https://issues.apache.org/jira/browse/ARCHETYPE-637
You have found a bug or you have an idea for a cool new feature? Contributing code is a great way to give something back to the open source community. Before you dig right into the code, there are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
We accept Pull Requests via GitHub. The developer mailing list is the main channel of communication for contributors.
There are some guidelines which will make applying PRs easier for us:
git diff --check
before committing.[ARCHETYPE-XXX] - Subject of the JIRA Ticket Optional supplemental description.
mvn -Prun-its verify
to assure nothing else was accidentally broken.If you plan to contribute on a regular basis, please consider filing a contributor license agreement.
For changes of a trivial nature to comments and documentation, it is not always necessary to create a new ticket in JIRA. In this case, it is appropriate to start the first line of a commit with ‘(doc)’ instead of a ticket number.