tree 5f6fe5b5abefd883820565c34f1456b16b00b814
parent b00750b221e7a1d105fd4110e5fcd0ec31d68d81
author Nikhil Kak <nkak@vmware.com> 1611362581 -0800
committer kaknikhil <nkak@vmware.com> 1612904796 -0800

DL: Fix validation in fit, fit multiple, evaluate and predict

JIRA: MADLIB-1464

Previously while calling fit/fit_multiple/evaluate/predict with invalid
input and output tables (null or missing), we would print the wrong
error message. This commit refactors the code so that we print the
expected error message.

Refactored the validator code such that we don't need to create the info
and summary table names in the fit multiple class. Instead we do that in
the validator and then the validator object can be used to get the table
names. This makes it easier to validate all the tables inside the
validator class.  This commit also refactors the code so that we move
all the validation code inside the validator class except for the source
table validation since that needs to be validated before we call the
get_data_distribution_per_segment function which has to be called before
the validator constructor.

To test this, we created a plpython function that asserts that the query
failed with the expected error message. Added a couple of wrapper
function on top of this function that test for null input and output tables.

Co-authored-by: Ekta Khanna <ekhanna@vmware.com>