tree c435fc734424dd8a1ef06a6dd818ba5b95486652
parent 4bac9009f9c3be9378873fd5e9bbb7247c55c9e2
author Nikhil Kak <nkak@vmware.com> 1614219632 -0800
committer Ekta Khanna <ekhanna@pivotal.io> 1614892697 -0800

MLP: Fix bug in weights argument

JIRA: MADLIB-1471

When passing in the weights param as a column in the table, it would
fail with the error `column does not exist`. This column was missed when
calling the step function. If it were passed in as a constant value,
this would work fine. We fixed this by adding the weights column to the
normalized/scaled table.

Additionally, there was a bug in validating the
weights column type, it validated only for integer and float types and
would fail for other numeric types. The intented column type was all
numeric types.
This commit fixes both these bugs and adds tests for
passing in weights as a table column.

Co-authored-by: Ekta Khanna <ekhanna@vmware.com>