commit 0aefb1481307db29e078a0ea0c4630ee03999f49
author Orhan Kislal <okislal@apache.org> Fri Feb 05 19:41:57 2021 +0300
committer Orhan Kislal <okislal@pivotal.io> Wed Feb 17 23:07:21 2021 +0300
tree d3d64309236e95f801dddc9fd373ef958ce95a57
parent 469267916542ca7c302d97e22e03374694ae0d3a

Kmeans: Fix auto kmeans tests

The auto kmeans dev check tests were using the incorrect column
for expr_point which caused some flaky tests.

src/ports/postgres/modules/kmeans/test/kmeans.sql_in

diff --git a/src/ports/postgres/modules/kmeans/test/kmeans.sql_in b/src/ports/postgres/modules/kmeans/test/kmeans.sql_in
index 6e86c82..614b630 100644
--- a/src/ports/postgres/modules/kmeans/test/kmeans.sql_in
+++ b/src/ports/postgres/modules/kmeans/test/kmeans.sql_in
@@ -87,7 +87,7 @@
 
 -- Test kmeanspp_auto
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 0.1, 'elbow');
 
 SELECT assert(
@@ -96,7 +96,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 0.1, 'silhouette');
 
 SELECT assert(
@@ -105,7 +105,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 0.1, 'both');
 
 SELECT assert(
@@ -114,7 +114,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8]);
+SELECT * FROM kmeanspp_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8]);
 
 SELECT assert(
         silhouette > 0 AND objective_fn > 0,
@@ -123,7 +123,7 @@
 
 -- Test kmeans_random_auto
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 'elbow');
 
 SELECT assert(
@@ -132,7 +132,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 'El');
 
 SELECT assert(
@@ -141,7 +141,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[5,6,7,8]);
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[5,6,7,8]);
 
 SELECT assert(
         silhouette > 0 AND objective_fn > 0,
@@ -154,7 +154,7 @@
 
 -- Unordered k list test
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[12,3,5,6,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[12,3,5,6,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 'silhouette');
 
 -- Silhouette Tests
@@ -200,7 +200,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 'silhouetTe');
 
 SELECT assert(
@@ -209,7 +209,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 'siL');
 
 SELECT assert(
@@ -218,7 +218,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 'both');
 
 SELECT assert(
@@ -228,7 +228,7 @@
 FROM autokm_out_summary;
 
 DROP TABLE IF EXISTS autokm_out,autokm_out_summary;
-SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'array[x,y]', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
+SELECT * FROM kmeans_random_auto('kmeans_2d', 'autokm_out', 'position', ARRAY[2,3,4,5,6,7,8], 'MADLIB_SCHEMA.squared_dist_norm2',
                        'MADLIB_SCHEMA.avg', 20, 0.001, 'b');
 
 SELECT assert(