tree fd6659fdbf023128fcb74dd383c8c5a4f865b599
parent 2f0d191452b9a02dcccd60cf551b450801668203
author Robert Muir <rmuir@apache.org> 1613841092 -0500
committer Robert Muir <rmuir@apache.org> 1613841092 -0500
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEEZmGbo8Aw3VU2JRMDgXrh3TItfsoFAmAxRK4ACgkQgXrh3TIt
 fspNXA/+Pezwjz/amVsO9ysSwt0MHtzMWQ8oAQEDnlyvuxvUqCV8qz0vGevYGOM0
 6SQ5/MPlyzOp6QCDsE/2sZq4sqoJb6OlCEIglxPtDKijeZtEzh6OjtWUmLcbYYLs
 5T2vGen4Szg3vFu5om7CM7Sc+H8Bb7nbxPRsKCD/qHcg6Gx/EDdvon6eXfxju4dI
 LsWNLT4BV7BpiACpf7AhzcZjj0MNqaXCkhJIO8V29p2CLwWRdzANfJpEYShsK6xv
 oy7DSz+lzYENxV83eIIU5fNXEJHP2bzo0rACKUHAx7o3/Gx+aEPOvaJqHtukExJ6
 5p12BCAJjV4mjwmqtseBDr3XnWJQ2A4IoDiSwMcFD1Jvzajcz8vmEDiCUzxl3Wp3
 og1vHyo1fay2VhDjkW8dA/S1t9JSVPrX2u1ZYHZ72KrF+XUW6OkePASfqcJP0ZrR
 6wKLDlc45T5yLdYrndTRg5LnyfpABmXcDrmU4KSDVToLn7r96aphpG1nwOifrElp
 rMKU2ldsmg8EaPn7cBFrl9/ekbLOk5yhFNXdG7L/8PuPbPk/PVrO8EzOjojVJws5
 2zlQpvyaKyGKDRrlh6QXYeD0mibrUkCpQ8V0Vb4AnY1fJqHTMNiRCCkh2YONonW8
 J+ack6tapVye5oyNjbl605AYKRCuYeGpiz0ozRTy7kTwQBI3TT4=
 =cqud
 -----END PGP SIGNATURE-----

LUCENE-9480: Make DataInput.skipBytes(long) abstract

skipBytes() is a "relative" version of seek(), but DataInput previously
implemented it via read() calls, because DataInput's API does not
include absolute positioning methods (seek, getFilePointer).

This resulted in inefficiencies: calls to skipBytes() would cause
buffers to be allocated, bytes copied, etc.

Instead, make the subclass implement skipBytes() explicitly. The old
DataInput implementation is marked deprecated and renamed to skipBytesSlowly().

Some subclasses still implement skipBytes() via skipBytesSlowly(), to be
fixed in future improvements.