)]}' { "commit": "b5f6ea2df90372cbe3bc679e6fffa07b984fdb6e", "tree": "53244c5366f318962ddaf92bfcfc46ee6e39c556", "parents": [ "5e790e1c04985b35a42cc820ed1d1741a0bc0e8d" ], "author": { "name": "Erik Mavrinac", "email": "erikmav@microsoft.com", "time": "Wed Mar 20 09:00:06 2024 -0700" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Mar 20 17:00:06 2024 +0100" }, "message": "Nullability and modernization updates, part 3 (#126)\n\n* Nullability and modernization updates, part 3\r\n\r\n* PR comments and fix remoting NDC test\r\n\r\n* Additional PR comment", "tree_diff": [ { "type": "modify", "old_id": "511987409fe77c2f266ea51045b0ef5ff432effa", "old_mode": 33188, "old_path": "src/log4net.Tests/Appender/RemotingAppenderTest.cs", "new_id": "511b22110449ffd83f9074a1865eb98f337d2504", "new_mode": 33188, "new_path": "src/log4net.Tests/Appender/RemotingAppenderTest.cs" }, { "type": "modify", "old_id": "83602f882163ea95cbe71b225c26f6340a01da67", "old_mode": 33188, "old_path": "src/log4net.Tests/Appender/StringAppender.cs", "new_id": "90e0c6ef3f02645ed6a7a12131b423a7708f0593", "new_mode": 33188, "new_path": "src/log4net.Tests/Appender/StringAppender.cs" }, { "type": "modify", "old_id": "8d61a39a98a56ac51d7c95e4f41d0249c2a6207e", "old_mode": 33188, "old_path": "src/log4net.Tests/Context/LogicalThreadContextTest.cs", "new_id": "b4861e0ffbaaa8462ea2cf1003e6022f4bdcaa39", "new_mode": 33188, "new_path": "src/log4net.Tests/Context/LogicalThreadContextTest.cs" }, { "type": "modify", "old_id": "f08a63cb7f14736a50d17e705f18ea64730d0357", "old_mode": 33188, "old_path": "src/log4net.Tests/Context/ThreadContextTest.cs", "new_id": "a01ca037d998ed27f1db3861abace5755e41d277", "new_mode": 33188, "new_path": "src/log4net.Tests/Context/ThreadContextTest.cs" }, { "type": "modify", "old_id": "024e03d91e23972215b215bfb2d0190fb4acfe62", "old_mode": 33188, "old_path": "src/log4net.Tests/Core/DefaultRepositorySelectorTest.cs", "new_id": "a05259276855d1c3fb67cd04454f4b1f54d13882", "new_mode": 33188, "new_path": "src/log4net.Tests/Core/DefaultRepositorySelectorTest.cs" }, { "type": "modify", "old_id": "b03357b76acde2145702df9486b0c037fe40bf9a", "old_mode": 33188, "old_path": "src/log4net.Tests/Hierarchy/LoggerTest.cs", "new_id": "6dbd233192a6318ae433c52bcdefdfe4cdf4c063", "new_mode": 33188, "new_path": "src/log4net.Tests/Hierarchy/LoggerTest.cs" }, { "type": "modify", "old_id": "d9fcf4fe0b3ae0ab9bc8f3e09649895c652c7539", "old_mode": 33188, "old_path": "src/log4net.Tests/Util/LogLogTest.cs", "new_id": "4aed3a2f99fb185318647bbab455fefc2268f440", "new_mode": 33188, "new_path": "src/log4net.Tests/Util/LogLogTest.cs" }, { "type": "modify", "old_id": "51cf6bf8645af404ca1e80f10fccecbb585ac93d", "old_mode": 33188, "old_path": "src/log4net.Tests/Util/PropertiesDictionaryTest.cs", "new_id": "861b7acdb72646f84bcaadc35dcdaa322a30039c", "new_mode": 33188, "new_path": "src/log4net.Tests/Util/PropertiesDictionaryTest.cs" }, { "type": "modify", "old_id": "be31939aa1a386f2f4100a3adf82ff32fdd4d921", "old_mode": 33188, "old_path": "src/log4net/Config/BasicConfigurator.cs", "new_id": "7af9f90180a9eef676686fee53a4a22d02fed432", "new_mode": 33188, "new_path": "src/log4net/Config/BasicConfigurator.cs" }, { "type": "modify", "old_id": "48f22c3a224818076b83427ff202b822ed4c48b7", "old_mode": 33188, "old_path": "src/log4net/Config/XmlConfigurator.cs", "new_id": "29ecbabd8b33683ee62886e940578a7a49c5a9bf", "new_mode": 33188, "new_path": "src/log4net/Config/XmlConfigurator.cs" }, { "type": "modify", "old_id": "b6d6c24932f85f10c3271640b2e18acda69dc123", "old_mode": 33188, "old_path": "src/log4net/Config/XmlConfiguratorAttribute.cs", "new_id": "3579cdaee75499023cc4c395bfa93d8a27cbb521", "new_mode": 33188, "new_path": "src/log4net/Config/XmlConfiguratorAttribute.cs" }, { "type": "modify", "old_id": "58e84cf3f269de3f8157b944be3bcc2de041d2d3", "old_mode": 33188, "old_path": "src/log4net/Core/IFixingRequired.cs", "new_id": "2251135d10e6bb901b440a05972a56765d93fb76", "new_mode": 33188, "new_path": "src/log4net/Core/IFixingRequired.cs" }, { "type": "modify", "old_id": "fefbd205c1f2f4b552542be222865be628071889", "old_mode": 33188, "old_path": "src/log4net/Core/ILoggerWrapper.cs", "new_id": "3edde25ca0d4a4d518c857f015cec384bcc4f73b", "new_mode": 33188, "new_path": "src/log4net/Core/ILoggerWrapper.cs" }, { "type": "modify", "old_id": "6d73ee18ab467446bb22ef747536171a02a3ba63", "old_mode": 33188, "old_path": "src/log4net/Core/IOptionHandler.cs", "new_id": "aadf71cdd25bc838b5f1a830ed8dea0ded7cc51e", "new_mode": 33188, "new_path": "src/log4net/Core/IOptionHandler.cs" }, { "type": "modify", "old_id": "5e8295e7ff9373c34bc7a1535b151444b9960ee6", "old_mode": 33188, "old_path": "src/log4net/Core/LocationInfo.cs", "new_id": "a05adca1f7ac93b94c2fee0990346bc903b04f68", "new_mode": 33188, "new_path": "src/log4net/Core/LocationInfo.cs" }, { "type": "modify", "old_id": "e09b42284fdd3f530336d333b9acebe02bcaa327", "old_mode": 33188, "old_path": "src/log4net/Core/LoggerManager.cs", "new_id": "0a9a6915eda2071ffb5b39585af1dd09a971a759", "new_mode": 33188, "new_path": "src/log4net/Core/LoggerManager.cs" }, { "type": "modify", "old_id": "4498704613ed9a17a1637d6e4139f7e8b57eeb98", "old_mode": 33188, "old_path": "src/log4net/Core/LoggingEvent.cs", "new_id": "908d617d07f1cc62e5e43e6dfbccdec223c7ff10", "new_mode": 33188, "new_path": "src/log4net/Core/LoggingEvent.cs" }, { "type": "modify", "old_id": "b2b30e5de3fa76ad692429b5e23feb866bf8501e", "old_mode": 33188, "old_path": "src/log4net/Core/WrapperMap.cs", "new_id": "16613ac849a6bcd3d6037530053d639aae19948e", "new_mode": 33188, "new_path": "src/log4net/Core/WrapperMap.cs" }, { "type": "modify", "old_id": "4b0a3e0db291d3f8a3695094dd55d003d6135bc1", "old_mode": 33188, "old_path": "src/log4net/Filter/NdcFilter.cs", "new_id": "b7b1c874d612319a6f88af0af8223a7f4640707a", "new_mode": 33188, "new_path": "src/log4net/Filter/NdcFilter.cs" }, { "type": "modify", "old_id": "348eb07553095ecd5a69264c183ae80c2023f67a", "old_mode": 33188, "old_path": "src/log4net/Layout/LayoutSkeleton.cs", "new_id": "06b959f39227b22261d2cd1fcbfed8d421a187ab", "new_mode": 33188, "new_path": "src/log4net/Layout/LayoutSkeleton.cs" }, { "type": "modify", "old_id": "a64dbb98c915c0a7cd40e349d80d15888803be99", "old_mode": 33188, "old_path": "src/log4net/Layout/Pattern/NdcPatternConverter.cs", "new_id": "cc2293b204f7e8245400c9d6a9d715e956ac7822", "new_mode": 33188, "new_path": "src/log4net/Layout/Pattern/NdcPatternConverter.cs" }, { "type": "modify", "old_id": "c23ecf9a6f36beecd378a2e24c383d6efd5b8baf", "old_mode": 33188, "old_path": "src/log4net/Layout/XmlLayout.cs", "new_id": "c165074096f98384d285cf0ea7c0e7068325905b", "new_mode": 33188, "new_path": "src/log4net/Layout/XmlLayout.cs" }, { "type": "modify", "old_id": "798fcc6bbdf11520f661569584b0cda6d2d594ea", "old_mode": 33188, "old_path": "src/log4net/Layout/XmlLayoutBase.cs", "new_id": "0002c467dacc7e917aede2218a77b3d8af01919d", "new_mode": 33188, "new_path": "src/log4net/Layout/XmlLayoutBase.cs" }, { "type": "modify", "old_id": "ef69e23f769bf10ed484bbd393810714f9993f60", "old_mode": 33188, "old_path": "src/log4net/Layout/XmlLayoutSchemaLog4j.cs", "new_id": "734a1648b6ca0836f8e5e5d910ddc7ba56b56200", "new_mode": 33188, "new_path": "src/log4net/Layout/XmlLayoutSchemaLog4j.cs" }, { "type": "modify", "old_id": "939295e067ca9412650244cf4552bf3f66ef2de1", "old_mode": 33188, "old_path": "src/log4net/LogManager.cs", "new_id": "c78b7f066a49443043277cc17339f2e3aab144e1", "new_mode": 33188, "new_path": "src/log4net/LogManager.cs" }, { "type": "modify", "old_id": "ca399f667f9d9c4317263e5b5bf093cf9732e728", "old_mode": 33188, "old_path": "src/log4net/LogicalThreadContext.cs", "new_id": "f19e230bf4716972953f43a12cac678f6a73219d", "new_mode": 33188, "new_path": "src/log4net/LogicalThreadContext.cs" }, { "type": "modify", "old_id": "9109cc6c21b8c6085718845afa34c30686951a25", "old_mode": 33188, "old_path": "src/log4net/NDC.cs", "new_id": "ea939c9f45500441c809cfd8fb400cac436d76ad", "new_mode": 33188, "new_path": "src/log4net/NDC.cs" }, { "type": "modify", "old_id": "2f55243e3c68a667fdac81d060922df49e8dc8ce", "old_mode": 33188, "old_path": "src/log4net/Repository/Hierarchy/DefaultLoggerFactory.cs", "new_id": "3aea766b28b78f9307e637a8a08632290291a50e", "new_mode": 33188, "new_path": "src/log4net/Repository/Hierarchy/DefaultLoggerFactory.cs" }, { "type": "modify", "old_id": "144b5c405edac439601c2b992f5ad64626df3148", "old_mode": 33188, "old_path": "src/log4net/Repository/Hierarchy/Hierarchy.cs", "new_id": "56dd29639b8512642beb8ea1728d54f4c7586777", "new_mode": 33188, "new_path": "src/log4net/Repository/Hierarchy/Hierarchy.cs" }, { "type": "modify", "old_id": "9826a97c5463fbc23228097e907aa0ddbd368260", "old_mode": 33188, "old_path": "src/log4net/Repository/Hierarchy/ILoggerFactory.cs", "new_id": "5720d4e7a6b044cf436d88e4ac0671fb614b48da", "new_mode": 33188, "new_path": "src/log4net/Repository/Hierarchy/ILoggerFactory.cs" }, { "type": "modify", "old_id": "255a3b52f7ee241e26f2626f19316cc308f2c309", "old_mode": 33188, "old_path": "src/log4net/Repository/Hierarchy/Logger.cs", "new_id": "e04da5bd19b00b7e4531a051b08ccb5dc2a1adce", "new_mode": 33188, "new_path": "src/log4net/Repository/Hierarchy/Logger.cs" }, { "type": "modify", "old_id": "ee7216563656c4d44cce1d1f47b6461b3cafe30d", "old_mode": 33188, "old_path": "src/log4net/Repository/Hierarchy/LoggerKey.cs", "new_id": "de16cbcdb02a4478e66a784186fa46c244c248a8", "new_mode": 33188, "new_path": "src/log4net/Repository/Hierarchy/LoggerKey.cs" }, { "type": "modify", "old_id": "9262a4749d596355132a26fb9cbbaaa32d540ca8", "old_mode": 33188, "old_path": "src/log4net/Repository/Hierarchy/ProvisionNode.cs", "new_id": "4762851943821a09865d24e16bfff6ceeb5a6eb5", "new_mode": 33188, "new_path": "src/log4net/Repository/Hierarchy/ProvisionNode.cs" }, { "type": "modify", "old_id": "7f149ac6cd682cc2d1432fa3cc6e8ced9b2e979d", "old_mode": 33188, "old_path": "src/log4net/Repository/Hierarchy/XmlHierarchyConfigurator.cs", "new_id": "a1d7769e686af383aa58203da62480ce2d6752ee", "new_mode": 33188, "new_path": "src/log4net/Repository/Hierarchy/XmlHierarchyConfigurator.cs" }, { "type": "modify", "old_id": "ac6638a32874f445a2f86fb425fdcee20b6a3aca", "old_mode": 33188, "old_path": "src/log4net/Repository/ILoggerRepository.cs", "new_id": "ad0b0d9ef6a1b5bb9e57480d6da597bd93707797", "new_mode": 33188, "new_path": "src/log4net/Repository/ILoggerRepository.cs" }, { "type": "modify", "old_id": "11afa005308dafbac2358f4eb3878291bb305a4a", "old_mode": 33188, "old_path": "src/log4net/Repository/LoggerRepositorySkeleton.cs", "new_id": "ed0455935602b2d28cc032358028d13daf8890c3", "new_mode": 33188, "new_path": "src/log4net/Repository/LoggerRepositorySkeleton.cs" }, { "type": "modify", "old_id": "e84dba539758dcc72a7b47ed9ee00a1e8580e3b1", "old_mode": 33188, "old_path": "src/log4net/ThreadContext.cs", "new_id": "6d17de147b143b26d9b33e64f68cf88a6a216fa2", "new_mode": 33188, "new_path": "src/log4net/ThreadContext.cs" }, { "type": "modify", "old_id": "66ac7b7e8581c1213112188e045ead4bff68b0dc", "old_mode": 33188, "old_path": "src/log4net/Util/CompositeProperties.cs", "new_id": "5e1350f872f080d68d7581292b61d802b3f7e0fd", "new_mode": 33188, "new_path": "src/log4net/Util/CompositeProperties.cs" }, { "type": "modify", "old_id": "47274615782fb76c3ba135a657f0d5fb49621570", "old_mode": 33188, "old_path": "src/log4net/Util/ContextPropertiesBase.cs", "new_id": "b75b0d00bd9884d898edd04df441735bfc2fbbf8", "new_mode": 33188, "new_path": "src/log4net/Util/ContextPropertiesBase.cs" }, { "type": "modify", "old_id": "d516804b6e56e965554e66f25441c8905f04d6eb", "old_mode": 33188, "old_path": "src/log4net/Util/GlobalContextProperties.cs", "new_id": "9d5c1cecdd40f322f82042997258d569271d3c40", "new_mode": 33188, "new_path": "src/log4net/Util/GlobalContextProperties.cs" }, { "type": "modify", "old_id": "6a1d79efdd94e6ec9c89067099807599a091ba55", "old_mode": 33188, "old_path": "src/log4net/Util/LogLog.cs", "new_id": "4ce84aa5b141a1c2f388293913c7a0754186e9fe", "new_mode": 33188, "new_path": "src/log4net/Util/LogLog.cs" }, { "type": "modify", "old_id": "28020c5fbf9d5dd49934d150dee7012218aaac96", "old_mode": 33188, "old_path": "src/log4net/Util/LogicalThreadContextProperties.cs", "new_id": "f42a6d20b5d1f4ebe1af6064ab7c00d8fbcd582a", "new_mode": 33188, "new_path": "src/log4net/Util/LogicalThreadContextProperties.cs" }, { "type": "modify", "old_id": "6a922488f57c2aeac3b2b0d917bbbc25e5d993c8", "old_mode": 33188, "old_path": "src/log4net/Util/LogicalThreadContextStack.cs", "new_id": "fd407e37f106db1b939c1be8028e15bd5f60a79e", "new_mode": 33188, "new_path": "src/log4net/Util/LogicalThreadContextStack.cs" }, { "type": "modify", "old_id": "0d32d80e7f0b269c8c38320d3247780e05091e15", "old_mode": 33188, "old_path": "src/log4net/Util/LogicalThreadContextStacks.cs", "new_id": "f797f48e122b61c9f124b97ce04161c092817d2c", "new_mode": 33188, "new_path": "src/log4net/Util/LogicalThreadContextStacks.cs" }, { "type": "modify", "old_id": "8171213c1c0dcc6af78d056f83dcccd6945c55cb", "old_mode": 33188, "old_path": "src/log4net/Util/OptionConverter.cs", "new_id": "8e5033e224aa34428674621f653c7d8ab198fdec", "new_mode": 33188, "new_path": "src/log4net/Util/OptionConverter.cs" }, { "type": "modify", "old_id": "efa921a078d23099832d1e28c6a8b151a5b31c7d", "old_mode": 33188, "old_path": "src/log4net/Util/PatternConverter.cs", "new_id": "d5b3a35c0926ce50d17a1b5bc91f862847e6125a", "new_mode": 33188, "new_path": "src/log4net/Util/PatternConverter.cs" }, { "type": "modify", "old_id": "fb2ba939646194c9e0085cb0812d55fa0b8bb10b", "old_mode": 33188, "old_path": "src/log4net/Util/PatternStringConverters/EnvironmentFolderPathPatternConverter.cs", "new_id": "b59452acc593655d5deb4e51d505d9ed8ed898ff", "new_mode": 33188, "new_path": "src/log4net/Util/PatternStringConverters/EnvironmentFolderPathPatternConverter.cs" }, { "type": "modify", "old_id": "44428e1ef6fd7c45d95b7ad177a1206a26df9cb3", "old_mode": 33188, "old_path": "src/log4net/Util/PatternStringConverters/EnvironmentPatternConverter.cs", "new_id": "98d77f0449fa1907404856fa8db31c009e832ccc", "new_mode": 33188, "new_path": "src/log4net/Util/PatternStringConverters/EnvironmentPatternConverter.cs" }, { "type": "modify", "old_id": "0bd500f1468b597bee6e43d91238006fbf0a13c7", "old_mode": 33188, "old_path": "src/log4net/Util/PropertiesDictionary.cs", "new_id": "ced2c7273fa083dd63a8911fa0df3218a53ee27a", "new_mode": 33188, "new_path": "src/log4net/Util/PropertiesDictionary.cs" }, { "type": "modify", "old_id": "379a2854d27d3340af4ebe1a3c4390afaa9eed85", "old_mode": 33188, "old_path": "src/log4net/Util/PropertyEntry.cs", "new_id": "bac35c87cad0915111011079d30793485b322261", "new_mode": 33188, "new_path": "src/log4net/Util/PropertyEntry.cs" }, { "type": "modify", "old_id": "10d77b517e404370669d85271b6cc11f31c8d4fe", "old_mode": 33188, "old_path": "src/log4net/Util/ReadOnlyPropertiesDictionary.cs", "new_id": "1da7256ccc07cadb5473e8dc1adc35e43c72e862", "new_mode": 33188, "new_path": "src/log4net/Util/ReadOnlyPropertiesDictionary.cs" }, { "type": "modify", "old_id": "2a945315da708dff779c4fd7073512c39cb07df6", "old_mode": 33188, "old_path": "src/log4net/Util/SystemStringFormat.cs", "new_id": "65d7bc64a8d45b2d882d44db0de07d69b3d78f43", "new_mode": 33188, "new_path": "src/log4net/Util/SystemStringFormat.cs" }, { "type": "modify", "old_id": "39040a61415720a5a8c03d2d79a2cdbd075ad3c6", "old_mode": 33188, "old_path": "src/log4net/Util/ThreadContextProperties.cs", "new_id": "939f8f73878ad430c876b12a79fd306120d043ce", "new_mode": 33188, "new_path": "src/log4net/Util/ThreadContextProperties.cs" }, { "type": "modify", "old_id": "5beb1dd66018965c978888005d71d61fe400f044", "old_mode": 33188, "old_path": "src/log4net/Util/ThreadContextStack.cs", "new_id": "ff72943dc613e4e28041d42f8692b3e9ebbb8544", "new_mode": 33188, "new_path": "src/log4net/Util/ThreadContextStack.cs" }, { "type": "modify", "old_id": "eaf29adacdbea02d3fb16ae596142f7a62d36127", "old_mode": 33188, "old_path": "src/log4net/Util/TypeConverters/ConverterRegistry.cs", "new_id": "fb0b4cad18fd55513faca66f01faf5e33b4d40cf", "new_mode": 33188, "new_path": "src/log4net/Util/TypeConverters/ConverterRegistry.cs" } ] }