LOG4J2-2919
Call ReliabilityStrategy's beforeStopAppenders() method before stopping AsyncAppenders
to avoid errors caused by logging with AsyncAppender while system is reconfiguring
Submitted by: gengyuanzhe <gengyuanzhe@gmail.com>
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
index 47794fa..3240332 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/config/AbstractConfiguration.java
@@ -370,6 +370,12 @@
asyncLoggerConfigDisruptor.stop(timeout, timeUnit);
}
+ LOGGER.trace("{} notifying ReliabilityStrategies that appenders will be stopped.", cls);
+ for (final LoggerConfig loggerConfig : loggerConfigs.values()) {
+ loggerConfig.getReliabilityStrategy().beforeStopAppenders();
+ }
+ root.getReliabilityStrategy().beforeStopAppenders();
+
// Stop the appenders in reverse order in case they still have activity.
final Appender[] array = appenders.values().toArray(new Appender[appenders.size()]);
final List<Appender> async = getAsyncAppenders(array);
@@ -381,12 +387,6 @@
}
}
- LOGGER.trace("{} notifying ReliabilityStrategies that appenders will be stopped.", cls);
- for (final LoggerConfig loggerConfig : loggerConfigs.values()) {
- loggerConfig.getReliabilityStrategy().beforeStopAppenders();
- }
- root.getReliabilityStrategy().beforeStopAppenders();
-
LOGGER.trace("{} stopping remaining Appenders.", cls);
int appenderCount = 0;
for (int i = array.length - 1; i >= 0; --i) {
