| commit | a97cdd554d109e6e1fa066b730f3a0b5793f8f9e | [log] [tgz] |
|---|---|---|
| author | Ralph Goers <rgoers@apache.org> | Sun May 30 07:42:38 2010 +0000 |
| committer | Ralph Goers <rgoers@apache.org> | Sun May 30 07:42:38 2010 +0000 |
| tree | ffda0574a1e2910f813329e2321c4cacd1a0800f | |
| parent | 75b5d9657705d4cff5c0c6cac1343e2d927b67bc [diff] |
Comment on @doubt entries git-svn-id: https://svn.apache.org/repos/asf/logging/log4j/branches/BRANCH_2_0_EXPERIMENTAL/rgoers@949488 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java b/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java index 9113d7d..1e0a341 100644 --- a/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java +++ b/log4j2-api/src/main/java/org/apache/logging/log4j/MDC.java
@@ -33,7 +33,7 @@ * child thread automatically inherits a <em>copy</em> of the mapped * diagnostic context of its parent. * - * @doubt I'd throw the concept into a ThreadContext object. + * @doubt I'd throw the concept into a ThreadContext object. (RG) I agree - will revise this. */ public final class MDC {
diff --git a/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java b/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java index fb801d7..6c9d1f5 100644 --- a/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java +++ b/log4j2-api/src/main/java/org/apache/logging/log4j/NDC.java
@@ -83,7 +83,10 @@ * method. A thread may obtain a copy of its NDC with the {@link * #cloneStack cloneStack} method and pass the reference to any other * thread, in particular to a child. - * @doubt I'd combine MDC and NDC into a single ThreadContext object. + * @doubt I'd combine MDC and NDC into a single ThreadContext object. (RG) To be + * honest, I've always doubted the practicality of this class. An errant + * app that forgets to pop an element will screw it up. I only added it + * because Log4J 1.x supports it and it wasn't particularly hard to carry over. */ public class NDC {