|author||Thorsten Schöning <firstname.lastname@example.org>||Sun Aug 09 11:56:05 2020 +0200|
|committer||GitHub <email@example.com>||Sun Aug 09 11:56:05 2020 +0200|
Fixed an infinite loop in "Transcoder::encode" (#34) Fixed an infinite loop in "Transcoder::encode(const LogString&, std::wstring&)" by appending LOSSCHAR. The most likely alternative would be to throw on any invalid input instead, but that's not the case right now and LOSSCHAR used in other places as well. https://issues.apache.org/jira/browse/LOGCXX-398 Co-authored-by: Robert Middleton <firstname.lastname@example.org>
Issues are maintained in the Apache JIRA by default, so before posting pull requests, please have a look there if an associated issue with your problem/feature/... exists already. If not, it‘s generally OK to directly create pull requests IF code is already available, but please be somewhat verbose: Provide some background information about what actual problem the PR solves, why this needs to be solved etc. Don’t just provide commits about the fact that you changed something.
If any discussion is needed before actually having any code, simply create a ticket in JIRA or send a message to the corresponding mailing list. Thanks!