commit | 85e117c103f3311ae989894713a26be435b9bf70 | [log] [tgz] |
---|---|---|
author | Stephen Webb <stephen.webb@ieee.org> | Wed Sep 21 09:17:05 2022 +1000 |
committer | GitHub <noreply@github.com> | Wed Sep 21 09:17:05 2022 +1000 |
tree | 31f7e356eade8224238cff18bba1d02260404209 | |
parent | 4c631a7bda6557ea34474c0998a970187568c791 [diff] |
Use std::make_shared to create std::shared_ptr instances (#132) * Use std::make_shared to create std::shared_ptr instances as it makes only one allocation * Some previously private constructors have been made public as std::make_shared needs access to the constructor. While these constructors are not intended for client use, alternative[https://stackoverflow.com/questions/8147027/how-do-i-call-stdmake-shared-on-a-class-with-only-protected-or-private-const] approaches seem unnessessaryly complex.
Issues are maintained in the Apache JIRA by default, so before posting pull requests, please have a look there if an associated issue with your problem/feature/... exists already. If not, it‘s generally OK to directly create pull requests IF code is already available, but please be somewhat verbose: Provide some background information about what actual problem the PR solves, why this needs to be solved etc. Don’t just provide commits about the fact that you changed something.
If any discussion is needed before actually having any code, simply create a ticket in JIRA or send a message to the corresponding mailing list. Thanks!