client: fix extra construction of ColumnSchema

The VARCHAR patches introduced a line 'auto col = schema.column(idx)'
which ends up making a copy of the ColumnSchema object instead of taking
a reference to it. This is unnecessary and quite slow. This shows up as
a significant CPU consumer when running tpch_real_world insert workload.

Change-Id: Iafae805979495e7e15c5294a317d6e00255654e0
Reviewed-on: http://gerrit.cloudera.org:8080/15787
Reviewed-by: Andrew Wong <awong@cloudera.com>
Tested-by: Kudu Jenkins
1 file changed