apache /
kudu /
66c5f52ab46807f925c6826283f84ded4e193f18 [test] instantiate TsRecoveryITestDeathTest
As it turned out, the parameterized TsRecoveryITestDeathTest was not
instantiated. Digging into the history of changes, I found that [1]
introduced TEST_F --> TEST_P change without adding corresponding
instantiations for the parameterized test suite.
I fixed the test by adapting it for the parameterization it went through
and added the missing instantiation macro. In addition, [2] introduced
an extra DCHECK() into TabletReplica::FinishConsensusOnlyRound(). Once
instantiated, the test started hitting the DCHECK(). To address that
issue, I updated the test-only function AppendNoOpsToLogSync() in
log-test-base.h to fill in the 'noop_request' field along with setting
the 'op_type' field to NO_OP. With that, since I added some extra data
into a NO_OP log record, I also updated the reference size of the WAL
segment in Raft consensus log test.
[1] https://github.com/apache/kudu/commit/371a00b7aeba244aa63d92bf479cbb356b4dfbca
[2] https://github.com/apache/kudu/commit/bc817a44867c586bf4e0539aa564b282c666a49d
Change-Id: Iaf48782ad17ac40023ee94770820d8d403c5cf96
Reviewed-on: http://gerrit.cloudera.org:8080/18920
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <acelyc1112009@gmail.com>
3 files changed
