commit 0f3d439e2bab770d57e8b338f1267571686feb3c
author Marton Greber <greber.mx@gmail.com> Fri Dec 02 16:37:00 2022 +0100
committer Alexey Serbin <alexey@apache.org> Fri Dec 02 17:52:04 2022 +0000
tree 7274a10db409a2b982ff2120d7d5a16f3d94eeb9
parent f413f09b295e825a75371ac928c6a28323f6d45c

Fix RocksDB build on Apple Silicon

RocksDB fails to build on Apple Silicon. The build exits with multiple
undefined symbol linker errors. Removing "-L$PREFIX/lib" from the build
definition solves the problem.

This change makes the build successful on macOS and Linux as well.
I verified that there aren't any 'not found' shared objects, see below.

macOS (Apple Silicon):
$ otool -L ./thirdparty/installed/uninstrumented/lib/librocksdb.dylib
./thirdparty/installed/uninstrumented/lib/librocksdb.dylib:
@rpath/librocksdb.7.dylib (compatibility version 7.0.0, current version 7.7.3)
/usr/lib/libc++.1.dylib (compatibility version 1.0.0, current version 1300.23.0)
/usr/lib/libc++abi.dylib (compatibility version 1.0.0, current version 1300.23.0)
liblz4.1.dylib (compatibility version 1.0.0, current version 1.9.3)
/usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current version 1311.100.3)

Ubuntu (amd64):
$ ldd ./thirdparty/installed/uninstrumented/lib/librocksdb.so
linux-vdso.so.1 (0x00007ffc94f25000)
liblz4.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/uninstrumented/lib/liblz4.so.1 (0x00007fcfa5de1000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fcfa5bc2000)
libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fcfa5839000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fcfa549b000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fcfa5283000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fcfa4e92000)
/lib64/ld-linux-x86-64.so.2 (0x00007fcfa6bf4000)

Ubuntu (amd64):
$ ldd ./thirdparty/installed/tsan/lib/librocksdb.so
linux-vdso.so.1 (0x00007ffe0abfa000)
liblz4.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/liblz4.so.1 (0x00007f0c2428f000)
libc++.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/libc++.so.1 (0x00007f0c23f81000)
libc++abi.so.1 => /root/apache/dev/git/kudu/thirdparty/installed/tsan/lib/libc++abi.so.1 (0x00007f0c23d43000)
libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f0c239a5000)
libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f0c2378d000)
libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f0c2356e000)
libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f0c2317d000)
/lib64/ld-linux-x86-64.so.2 (0x00007f0c2530b000)
librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f0c22f75000)
libatomic.so.1 => /usr/lib/x86_64-linux-gnu/libatomic.so.1 (0x00007f0c22d6d000)

Change-Id: Iec61fff8c6fb3ddb68498c9782cf765638101262
Reviewed-on: http://gerrit.cloudera.org:8080/19308
Tested-by: Alexey Serbin <alexey@apache.org>
Reviewed-by: Alexey Serbin <alexey@apache.org>