commit ded3c313ae72f7aa3608abd822c957dcbde200b4
author Daniel Gruno <humbedooh@apache.org> Fri Feb 28 16:24:06 2020 -0600
committer GitHub <noreply@github.com> Fri Feb 28 16:24:06 2020 -0600
tree 60c7a539b01cf8d60eafdc140c7cc977e3930901
parent 10178eeea1f8a3688430952773f263aca04f450f

switch order, scale down hostname size

pam_duo/pam_duo.c

diff --git a/pam_duo/pam_duo.c b/pam_duo/pam_duo.c
index 07b6f87..75fc962 100644
--- a/pam_duo/pam_duo.c
+++ b/pam_duo/pam_duo.c
@@ -122,7 +122,7 @@
     duopam_const char *ip, *service, *user;
     const char *cmd, *p, *config, *host;
     // ASF hack: mix in hostname (whoami) with the command (cmd_extended)
-    char cmd_extended[256], whoami[1024];
+    char cmd_extended[256], whoami[128];
 
     int i, flags, pam_err, matched;
 
@@ -200,10 +200,10 @@
     } else if (strcmp(service, "sudo") == 0) {
         cmd = getenv("SUDO_COMMAND");
         // ASF Hack: fetch local FQDN
-        whoami[1023] = '\0';
-        gethostname(whoami, 1023);
+        whoami[127] = '\0';
+        gethostname(whoami, 128);
         // ASF Hack: Add hostname to command run
-        snprintf(cmd_extended, 256, "%s (%s)", cmd, whoami);
+        snprintf(cmd_extended, 256, "%s (%s)", whoami, cmd);
         cmd = (const char*) cmd_extended;
     } else if (strcmp(service, "su") == 0 || strcmp(service, "su-l") == 0) {
         /* Check calling user for Duo auth, just like sudo */