Differentiate descriptions of Address and Endpoint (#179)
diff --git a/api/v1alpha08/sonataflow_types.go b/api/v1alpha08/sonataflow_types.go
index 095e2b1..e4ab6dd 100644
--- a/api/v1alpha08/sonataflow_types.go
+++ b/api/v1alpha08/sonataflow_types.go
@@ -120,12 +120,14 @@
// SonataFlowStatus defines the observed state of SonataFlow
type SonataFlowStatus struct {
api.Status `json:",inline"`
+ // Address is used as a part of Addressable interface (status.address.url) for knative
// +optional
Address duckv1.Addressable `json:"address,omitempty"`
// keeps track of how many failure recovers a given workflow had so far
RecoverFailureAttempts int `json:"recoverFailureAttempts,omitempty"`
LastTimeRecoverAttempt metav1.Time `json:"lastTimeRecoverAttempt,omitempty"`
- Endpoint *apis.URL `json:"endpoint,omitempty"`
+ // Endpoint is an externally accessible URL of the workflow
+ Endpoint *apis.URL `json:"endpoint,omitempty"`
}
func (s *SonataFlowStatus) GetTopLevelConditionType() api.ConditionType {
diff --git a/bundle/manifests/sonataflow.org_sonataflows.yaml b/bundle/manifests/sonataflow.org_sonataflows.yaml
index 936263c..5f1d39d 100644
--- a/bundle/manifests/sonataflow.org_sonataflows.yaml
+++ b/bundle/manifests/sonataflow.org_sonataflows.yaml
@@ -2149,11 +2149,8 @@
description: SonataFlowStatus defines the observed state of SonataFlow
properties:
address:
- description: "Addressable provides a generic mechanism for a custom
- resource definition to indicate a destination for message delivery.
- \n Addressable is the schema for the destination information. This
- is typically stored in the object's `status`, as this information
- may be generated by the controller."
+ description: Address is used as a part of Addressable interface (status.address.url)
+ for knative
properties:
CACerts:
description: CACerts is the Certification Authority (CA) certificates
@@ -2195,6 +2192,7 @@
type: object
type: array
endpoint:
+ description: Endpoint is an externally accessible URL of the workflow
type: string
lastTimeRecoverAttempt:
format: date-time
diff --git a/config/crd/bases/sonataflow.org_sonataflows.yaml b/config/crd/bases/sonataflow.org_sonataflows.yaml
index 46091ac..0020731 100644
--- a/config/crd/bases/sonataflow.org_sonataflows.yaml
+++ b/config/crd/bases/sonataflow.org_sonataflows.yaml
@@ -2150,11 +2150,8 @@
description: SonataFlowStatus defines the observed state of SonataFlow
properties:
address:
- description: "Addressable provides a generic mechanism for a custom
- resource definition to indicate a destination for message delivery.
- \n Addressable is the schema for the destination information. This
- is typically stored in the object's `status`, as this information
- may be generated by the controller."
+ description: Address is used as a part of Addressable interface (status.address.url)
+ for knative
properties:
CACerts:
description: CACerts is the Certification Authority (CA) certificates
@@ -2196,6 +2193,7 @@
type: object
type: array
endpoint:
+ description: Endpoint is an externally accessible URL of the workflow
type: string
lastTimeRecoverAttempt:
format: date-time
diff --git a/operator.yaml b/operator.yaml
index 710fe88..b74ff86 100644
--- a/operator.yaml
+++ b/operator.yaml
@@ -2579,11 +2579,8 @@
description: SonataFlowStatus defines the observed state of SonataFlow
properties:
address:
- description: "Addressable provides a generic mechanism for a custom
- resource definition to indicate a destination for message delivery.
- \n Addressable is the schema for the destination information. This
- is typically stored in the object's `status`, as this information
- may be generated by the controller."
+ description: Address is used as a part of Addressable interface (status.address.url)
+ for knative
properties:
CACerts:
description: CACerts is the Certification Authority (CA) certificates
@@ -2625,6 +2622,7 @@
type: object
type: array
endpoint:
+ description: Endpoint is an externally accessible URL of the workflow
type: string
lastTimeRecoverAttempt:
format: date-time
