| id,base_repo_id,head_repo_id,status,title,description,url,author_name,author_id,parent_pr_id,pull_request_key,created_date,merged_date,closed_date,type,component,merge_commit_sha,head_ref,base_ref,base_commit_sha,head_commit_sha,_raw_data_params,_raw_data_table,_raw_data_id,_raw_data_remark |
| github:GithubPullRequest:1:203756736,github:GithubRepo:1:134018330,github:GithubRepo:1:142234748,MERGED,pre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker listpre-allocate the capacity of the worker list,"""fix #3 \r\n* 链表实际测过， 性能相差无几， 但内存占用高了几倍\r\n* 初始化`Pool`和`PoolFunc`是给定了个默认的worker capacity\r\n* 优化了下其他代码""",https://github.com/panjf2000/ants/pull/4,barryz,github:GithubAccount:1:16658738,,4,2018-07-25T08:19:30.000+00:00,2018-07-26T02:32:41.000+00:00,2018-07-26T02:32:41.000+00:00,,,3ddd58c390b0f928a5782c235f90ad0c9c21312c,pre_allocate,master,f5b37d0798a8e4c6780a1e08270fa50e979aa1d7,83042d709562a53973c78901ca5df7e7cddbe677,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,246, |
| github:GithubPullRequest:1:211603583,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,fix goroutine leak,"""n++, will cause workers[0] leak""",https://github.com/panjf2000/ants/pull/8,hongli-my,github:GithubAccount:1:8597823,,8,2018-08-29T01:35:54.000+00:00,,2018-10-30T00:12:13.000+00:00,,,74ba726f34abe487b7defac6bb9bebf24d342377,dev,master,666635c65d8d3bb1223b819325e0bd23c81f2733,afd687164b13280199208ec4869709edcf02b52d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,247, |
| github:GithubPullRequest:1:212277907,github:GithubRepo:1:134018330,github:GithubRepo:1:146845386,CLOSED,Update pool.go,"""#活着的孩子不想当孤儿\r\n\tHopefully:\r\n\tchildren := []*child{C1,C2,C3,C4,C5,C6,C7}\r\n\tIn fact:\r\n\tchildren := []*child{C1,C4,C2,C3,C5,C6,C7}""",https://github.com/panjf2000/ants/pull/9,Nonnnnnnnnn,github:GithubAccount:1:42808204,,9,2018-08-31T05:29:36.000+00:00,,2018-08-31T13:40:33.000+00:00,,,f14d3f91f68d0bc23fe42aa413e98005f6575045,patch-1,master,666635c65d8d3bb1223b819325e0bd23c81f2733,2726d42ea62857283ee73ef3611e379b60974ad2,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,248, |
| github:GithubPullRequest:1:216254598,github:GithubRepo:1:134018330,github:GithubRepo:1:149267177,CLOSED,graceful exit,"""graceful exit""",https://github.com/panjf2000/ants/pull/11,shanhuhai5739,github:GithubAccount:1:3794113,,11,2018-09-18T10:15:01.000+00:00,,2018-12-03T03:52:35.000+00:00,,,6a87067eb3d6440e5db17f31d4bc12ac291633f4,master,develop,833b6e29acfb2f16e3cf7fc92c79763847c319f4,a03eccc794870f0a2e55a5cb8344ea47f2a0001d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,249, |
| github:GithubPullRequest:1:218939809,github:GithubRepo:1:134018330,github:GithubRepo:1:150579999,MERGED,❓解决死循环导致cpu占用率过高,"""使用了cond 条件变量来阻塞Submit goroutine。潘少，你再仔细琢磨琢磨，看下有何不妥？""",https://github.com/panjf2000/ants/pull/13,liyonglion,github:GithubAccount:1:12890888,,13,2018-09-28T11:37:28.000+00:00,2018-09-29T11:29:54.000+00:00,2018-09-29T11:29:54.000+00:00,,,9a3b5cd25344822bca7684f87d9e123890a7bf59,master,master,af376f1b7b59dc488458bcecd4273f0fcde33c55,1846b4392a3a20e6bf1a7431b67f86bd43e0f0b9,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,250, |
| github:GithubPullRequest:1:219363161,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Remove meaningless if statements,"""""",https://github.com/panjf2000/ants/pull/14,SimePel,github:GithubAccount:1:20608155,,14,2018-10-01T12:48:11.000+00:00,2018-10-02T13:52:27.000+00:00,2018-10-02T13:52:27.000+00:00,,,29730bb70343924a2f56a13a9799611dd1cd27fd,master,master,1b62696050b7030106291980d5220f886b017eff,5ed168767a771e3802252020b9821610380ed1a4,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,251, |
| github:GithubPullRequest:1:219936521,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Fixes to benchmarks and added semaphore comparison,"""Benchmark results with Param=0, as time.Sleep is not stable on Windows\r\n\r\nAlso Go 1.11 has bunch of improvements:\r\n\r\n```\r\ngoos: windows\r\ngoarch: amd64\r\npkg: github.com/panjf2000/ants\r\nBenchmarkGoroutineWithFunc-8 1 3530220300 ns/op 207472 B/op 506 allocs/op\r\nBenchmarkSemaphoreWithFunc-8 1 4391916400 ns/op 20944 B/op 57 allocs/op\r\nBenchmarkAntsPoolWithFunc-8 1 5496395400 ns/op 164240 B/op 2059 allocs/op\r\nBenchmarkGoroutine-8 1 3327413400 ns/op 1552 B/op 5 allocs/op\r\nBenchmarkSemaphore-8 1 4499816000 ns/op 1264 B/op 5 allocs/op\r\nBenchmarkAntsPool-8 1 5456432100 ns/op 49208 B/op 809 allocs/op\r\nPASS\r\n```""",https://github.com/panjf2000/ants/pull/15,egonelbre,github:GithubAccount:1:192964,,15,2018-10-03T07:16:16.000+00:00,2018-10-03T12:33:59.000+00:00,2018-10-03T12:33:59.000+00:00,,,c10f80f7b760ba68bef1759f6e7921ba5e34b889,fix-benchmarks,master,29730bb70343924a2f56a13a9799611dd1cd27fd,3070771e41f0df591619c94ed0bc5c8025451302,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,252, |
| github:GithubPullRequest:1:222703171,github:GithubRepo:1:134018330,github:GithubRepo:1:152956614,CLOSED,bugfix(check max pool size),"""if you limit max goroutine to math.Maxint32 as your code `int32(pool size)`\r\nI think should check max Goroutine size, otherwise size overflow to negative？\r\n""",https://github.com/panjf2000/ants/pull/16,rikewang,github:GithubAccount:1:24841832,,16,2018-10-14T09:21:41.000+00:00,,2018-12-03T03:53:31.000+00:00,,,1399cfa28f6751f769a985206daecb56a08b2de9,bugfix_check_max_pool_size,master,711dbdb7a222771ce15aaee1bb7b7c6e9731f208,439348b027031c793e54669fcd74eb4964c15055,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,253, |
| github:GithubPullRequest:1:231840723,github:GithubRepo:1:134018330,github:GithubRepo:1:158152223,MERGED,Possible memory leak because of Ticker,"""// NewTicker returns a new Ticker containing a channel that will send the\r\n// time with a period specified by the duration argument.\r\n// It adjusts the intervals or drops ticks to make up for slow receivers.\r\n// The duration d must be greater than zero; if not, NewTicker will panic.\r\n// Stop the ticker to release associated resources.\r\nfunc NewTicker(d Duration) *Ticker {\r\n……\r\n}""",https://github.com/panjf2000/ants/pull/19,zplzpl,github:GithubAccount:1:7931755,,19,2018-11-19T03:03:09.000+00:00,2018-12-01T15:49:32.000+00:00,2018-12-01T15:49:32.000+00:00,,,639f55c4c94407632a1c5e34cd71784524de0757,hotfix/tickerStop,develop,92acf74bb71c1dc1758c61346c88325284978b3e,e7bacd0f127fcde1399f92452bd0039f58916fed,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,254, |
| github:GithubPullRequest:1:246250598,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,feature: add PanicHandler,"""@panjf2000 PTAL\r\nFix #22 \r\nSigned-off-by: Cholerae Hu <choleraehyq@gmail.com>""",https://github.com/panjf2000/ants/pull/23,choleraehyq,github:GithubAccount:1:8923413,,23,2019-01-21T10:58:15.000+00:00,2019-01-22T05:41:34.000+00:00,2019-01-22T05:41:34.000+00:00,,,9158bd37025ccdd29d6346a6639a282e0060c7e2,panichandler,master,812dd4e01075be3cf97429a43abaf6837908cdcd,5bbc9e170bbee27c37bcc30da3da75b4531d1edb,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,255, |
| github:GithubPullRequest:1:267414275,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,goreport: lint warning on code comment structure,"""Added a newline between group comment and exported variable line 😄""",https://github.com/panjf2000/ants/pull/30,sarathsp06,github:GithubAccount:1:964542,,30,2019-04-04T11:52:48.000+00:00,2019-04-23T11:11:58.000+00:00,2019-04-23T11:11:58.000+00:00,,,dec04010834ccd3691eb1776045ce3b9310ce26c,patch-1,master,4ae3fb8dc413492862469027bb58cb45b77338f1,ec5d1f3b8107265cb53536975504c7cda4f6d68f,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,256, |
| github:GithubPullRequest:1:292246524,github:GithubRepo:1:134018330,github:GithubRepo:1:194015289,CLOSED,handle job panic,"""""",https://github.com/panjf2000/ants/pull/36,king526,github:GithubAccount:1:38849208,,36,2019-06-27T03:27:05.000+00:00,,2019-08-17T20:32:34.000+00:00,,,95e11bf85f18a80197918d15a19ec10f41903d63,master,master,05e96abd6103ae7b70436abe58dbc0ad7e740929,39f04c6e65b76b5f20abd3ca0606db4cd038e5c2,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,257, |
| github:GithubPullRequest:1:300598936,github:GithubRepo:1:134018330,github:GithubRepo:1:198582966,MERGED,优化清理速度并修复内存泄漏,"""""",https://github.com/panjf2000/ants/pull/39,wwjiang,github:GithubAccount:1:1290360,,39,2019-07-24T07:41:02.000+00:00,2019-07-26T04:00:12.000+00:00,2019-07-26T04:00:12.000+00:00,,,21a109c7f0873c8f466d6710de23474968940011,master,master,fc48d32604efc2b36d144b8f83d34c1aa1fda1c9,b44a12884b495713a44f796981267ed87134decb,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,258, |
| github:GithubPullRequest:1:301421607,github:GithubRepo:1:134018330,github:GithubRepo:1:198955529,MERGED,"optimize memory allocation, change the default pool param and add the log of panic stack.","""Hi, I am using it on my online server which almost need 5 million goroutines on each go service.\r\nI'm divided into 10 small pools, because a pool of five million will slow down the speed associated with the slice.\r\nI made some small optimizations, I hope this is useful.\r\noptimize memory allocation, change the default pool param and add the log of panic stack.\r\nbtw, the default value DEFAULT_CLEAN_INTERVAL_TIME, one second is too short-lived. when the pool size is too large , Performance will drop .\r\n""",https://github.com/panjf2000/ants/pull/40,Anteoy,github:GithubAccount:1:17495446,,40,2019-07-26T07:07:06.000+00:00,2019-07-26T15:22:26.000+00:00,2019-07-26T15:22:26.000+00:00,,,3e1c7a03a512a7de8c9049d56237e5d2de2f30eb,master,master,f447bf104a4eff069b6019db406c31dd54d7b3ef,5dc8b9a71737eb57dc03fbbe3eb9010ff6c3fbb6,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,259, |
| github:GithubPullRequest:1:308859272,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,support nonblocking submit and max blocking limit setting,"""Signed-off-by: Cholerae Hu <choleraehyq@gmail.com>""",https://github.com/panjf2000/ants/pull/41,choleraehyq,github:GithubAccount:1:8923413,,41,2019-08-20T03:24:27.000+00:00,2019-08-20T10:55:19.000+00:00,2019-08-20T10:55:19.000+00:00,,,faef79b7d8a4876da8a215d7794cce20c710aaa2,nonblocking,master,dc8169d5c2645bfc507d6993b7d215326300f31b,58466b12b03a603d9f0331bbcc64a7557b27865d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,260, |
| github:GithubPullRequest:1:311420898,github:GithubRepo:1:134018330,github:GithubRepo:1:134018330,MERGED,Create CODE_OF_CONDUCT.md,"""""",https://github.com/panjf2000/ants/pull/48,panjf2000,github:GithubAccount:1:7496278,,48,2019-08-27T14:44:03.000+00:00,2019-08-27T14:46:22.000+00:00,2019-08-27T14:46:22.000+00:00,,,d5eded45bffe827e5a64a3376c4b94f08b641031,add-code-of-conduct-1,master,44aec9954f58987c37d5937ba590bbf0812a32de,bba6c12b60eff3445adcc168fff3bfdcad9e2571,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,261, |
| github:GithubPullRequest:1:316337433,github:GithubRepo:1:134018330,github:GithubRepo:1:207765423,MERGED,Invoke decRunning() when revertWorker() returns false,"""Signed-off-by: Cholerae Hu <choleraehyq@gmail.com>\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [ ] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/51,choleraehyq,github:GithubAccount:1:8923413,,51,2019-09-11T08:46:23.000+00:00,2019-09-12T01:00:32.000+00:00,2019-09-12T01:00:32.000+00:00,,,d6cd5a7e726c9bb8578e7aabdbf3488dc8d080b6,fixbug,master,280ac345a860e794df1268e15112db9a863900ca,6495acc77318c3944e3edd3f983a03fc9027324a,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,262, |
| github:GithubPullRequest:1:325179595,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,add loop queue ,"""---\r\nname: Pull request\r\nabout: 抽象出worker队列的实现，使用原先和循环队列实现这个接口\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n抽象了 worker 队列，实现了两种队列的方式，也可以方便的新加队列实现，只要符合 WorkerQueue 即可\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n1. 抽象woker队列为WorkerQueue 的 interface{}\r\n2. 模仿之前的方式实现了 SliceQueue 队列，还是使用了 slice\r\n3. 新加了循环队列 LoopQueue，也是使用 slice 实现，但是会减少内存的copy操作(原先会在periodicallyPurge有slice拷贝的操作)\r\n4. 修改了在查询超时时间时，使用二分查找的算法。\r\n\r\n潘少，目前我修改了 pool。如果潘少觉得这个方案可行，我可以再把 PoolWithFunc 按照这种方式修改。\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/53,KevinBaiSg,github:GithubAccount:1:2813260,,53,2019-10-07T08:17:20.000+00:00,2019-10-09T16:59:19.000+00:00,2019-10-09T16:59:19.000+00:00,,,f0e23928f4388661a8e0f6f5ff93f8f9514a1762,feature/loopQueue,master,66350c88dbd991f49ca95454e2d8485ca990fd30,6ef45a0a1fd2ad8878c5684e9ec1baf8aab24f87,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,263, |
| github:GithubPullRequest:1:329127652,github:GithubRepo:1:134018330,github:GithubRepo:1:215736581,CLOSED,throw out default panic,"""<the Go programming language>\r\n5.10. Recover\r\nRecovering indiscriminately from panics is a dubious practice because the state of a package’s variables after a panic is rarely well defined or documented. Perhaps a critical update to a data structure was incomplete, a file or net work connection was opened but not closed, or a lock was acquired but not released. Furthermore, by replacing a crash with, say, a line in a log file, indiscriminate recovery may cause bugs to go unnoticed.\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [ ] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/54,polar9527,github:GithubAccount:1:8644923,,54,2019-10-17T08:18:41.000+00:00,,2019-10-18T02:07:14.000+00:00,,,f1ce1289901ab1bed876ec9ec21eb144d9c52b6d,master,master,52b301019a4bd8cb6b56a3b51d3087cd71b66386,979da84674d28c21394afec4b8e8559aed85d4eb,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,264, |
| github:GithubPullRequest:1:346931859,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,Refine the indentation of the sample code in READMEs,"""""",https://github.com/panjf2000/ants/pull/66,RealLiuSha,github:GithubAccount:1:5715152,,66,2019-11-29T07:50:17.000+00:00,,2019-11-29T07:52:04.000+00:00,,,1acafed7740d0daf1dcc3a30129798f59c234331,master,master,fd3841dd88c15fcc0e0ea94e606d980221ac5e09,b19edbd7b909527b2cc2a759e7a60133497f9dee,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,265, |
| github:GithubPullRequest:1:379435034,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Fix a bug that doesn't release lock,"""err!=nil时未释放锁，使用defer p.lock.Unlock()修复\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [ ] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/79,lam2003,github:GithubAccount:1:22312935,,79,2020-02-25T08:30:05.000+00:00,2020-02-26T03:15:03.000+00:00,2020-02-26T03:15:03.000+00:00,,,d8cb0361988bf8a0a2a5bee93a06f9c4e1b65e61,master,master,c3b448271b0f84fd3e850b679bf29e7965fe7608,e7a2d3706bf4d32f0e927258b10d2a3585b9ed7d,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,266, |
| github:GithubPullRequest:1:404931293,github:GithubRepo:1:134018330,github:GithubRepo:1:256385795,CLOSED,fix:v2 dir not exist,"""---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\nbug-fix\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\nI need to use this repo, but it has errors. \r\nThere is a internal dir, but no v2/internal and v2/internal is used in repo. i just added a new v2/internal dir copied from internal dir.\r\n\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [ ] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/87,shanghai-Jerry,github:GithubAccount:1:12420699,,87,2020-04-17T05:34:28.000+00:00,,2020-04-19T03:03:07.000+00:00,,,010ef635a955c8ab81620e78099440311f273111,master,master,f33679bb799fe76b52d47d3172c40ce229463198,402dcefd038c7db892b3c433d1d93e09a3e48652,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,267, |
| github:GithubPullRequest:1:410487606,github:GithubRepo:1:134018330,github:GithubRepo:1:259825622,MERGED,Fix indent on README,"""---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: 'Fix indent'\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\nNo.\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\nThere are wrong idents on README.md.\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/89,wreulicke,github:GithubAccount:1:12907474,,89,2020-04-29T04:51:26.000+00:00,2020-04-29T07:08:43.000+00:00,2020-04-29T07:08:43.000+00:00,,,88b5a85d64e3aa487f157dc6266472a7a14eeb0d,patch-1,master,f33679bb799fe76b52d47d3172c40ce229463198,51f1f518835109c3de3cfa42bf29a01cc5fcd788,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,268, |
| github:GithubPullRequest:1:415925259,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,支持配置workerChanCap大小,"""---\r\nname: Pull request\r\nabout: support customize workerChanCap \r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/91,lntotk,github:GithubAccount:1:5227289,,91,2020-05-11T07:40:41.000+00:00,,2020-05-11T09:27:30.000+00:00,,,ff938265a22ac26c4a2ff7ee0f696cf4fe9e3895,master,master,1c534853c887e0a7b0d56d51303bf09f201e26a0,b1ce6e8fb4f31b4d75b748bbe2d03c28e0f737f2,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,269, |
| github:GithubPullRequest:1:452382525,github:GithubRepo:1:134018330,github:GithubRepo:1:280806104,MERGED,chore: support go1.14,"""as title.""",https://github.com/panjf2000/ants/pull/100,appleboy,github:GithubAccount:1:21979,,100,2020-07-19T06:38:38.000+00:00,2020-07-19T14:59:48.000+00:00,2020-07-19T14:59:48.000+00:00,,,0a7be73d35726850863a80432dec0ac5c78cdfb4,patch,master,b2666199751ef4fe666c175ba667d18a182b67e0,18623ceb17a9230484ff5d1a31c3beb0b631a2f3,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,270, |
| github:GithubPullRequest:1:461992435,github:GithubRepo:1:134018330,github:GithubRepo:1:284629248,CLOSED,Add a Gitter chat badge to README.md,"""### panjf2000/ants now has a Chat Room on Gitter\n\n@panjf2000 has just created a chat room. You can visit it here: [https://gitter.im/ants-pool/ants](https://gitter.im/ants-pool/ants?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&content=body_link).\n\nThis pull-request adds this badge to your README.md:\n\n\n[](https://gitter.im/ants-pool/ants?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=body_badge)\n\nIf my aim is a little off, please [let me know](https://gitlab.com/gitlab-org/gitter/readme-badger/issues).\n\nHappy chatting.\n\n\nPS: [Click here](https://gitter.im/settings/badger/opt-out) if you would prefer not to receive automatic pull-requests from Gitter in future.\n""",https://github.com/panjf2000/ants/pull/103,gitter-badger,github:GithubAccount:1:8518239,,103,2020-08-03T07:12:25.000+00:00,,2020-08-03T07:17:52.000+00:00,,,acb7f9847897513820e2467ef9720cb213a97133,gitter-badge,master,c32db55d3e7e19d8300760de03584072b6a9de93,f323aef64aa8b47b777037502adf6eca0b2f4fd0,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,271, |
| github:GithubPullRequest:1:475457581,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Avoid memory leak,"""---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: 'avoid memory leaky'\r\nlabels: 'gc'\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n bug fix\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n 我认为在对stack,loop queue在出栈或出队需要对不使用的切片元素进行置为nil操作,因为是指针,不应该留在未使用的切片位置,在突发任务需要goroutine时,会分配大量的goWorker并进入工作,但是当没有突发任务时,这些都在空闲队列或队列中是没有回收的,但是当超过存活时间,进行回收时,还是有底层的数据持有(未置为nil),个人认为会占有大量的内存,这部份应该真正的交还给sync.Pool.\r\n 另外,假设在sync.Pool和切片底层数组同时持有同一个对象,不知道go的gc是什么行为? \r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/107,thinkgos,github:GithubAccount:1:49174849,,107,2020-08-28T15:02:33.000+00:00,2020-08-29T10:51:57.000+00:00,2020-08-29T10:51:57.000+00:00,,,ef6017217221e20416d886c0231dd5134752ef4e,master,master,21f632368adbd3b3af71038ab697a6585a40db62,e2ccffc1650009dcf72cf93dbe95888abfba63eb,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,272, |
| github:GithubPullRequest:1:496172205,github:GithubRepo:1:134018330,github:GithubRepo:1:300247425,CLOSED,Remove underscore from file names,"""\r\n## 1. Are you opening this pull request for bug-fixes, optimizations, or new features?\r\nFixing the file naming convention based on [this](https://golang.org/doc/effective_go.html#package-names).\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\nThere is no code change\r\n\r\n\r\n\r\n_(Feel free to reject this PR if you think it's unnecessary)_""",https://github.com/panjf2000/ants/pull/111,arjunmahishi,github:GithubAccount:1:11977524,,111,2020-10-01T11:08:20.000+00:00,,2020-10-04T07:42:53.000+00:00,,,21ae8e46646bff4ef8804892b5d2f064b0772efc,fix/file-naming-convention,master,ef6017217221e20416d886c0231dd5134752ef4e,7403b395ea8e1a39ca7a2f29aee7b4735cb988ef,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,273, |
| github:GithubPullRequest:1:502102437,github:GithubRepo:1:134018330,github:GithubRepo:1:303638681,MERGED,fix: Memory leak,"""Fixes #113""",https://github.com/panjf2000/ants/pull/114,Mutated1994,github:GithubAccount:1:29589055,,114,2020-10-13T08:37:37.000+00:00,2020-10-15T03:35:56.000+00:00,2020-10-15T03:35:56.000+00:00,,,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,master,master,ef6017217221e20416d886c0231dd5134752ef4e,00691c648a5b7d28dba5bcafa05d9bbccdf4d933,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,274, |
| github:GithubPullRequest:1:505486248,github:GithubRepo:1:134018330,github:GithubRepo:1:305101171,CLOSED,fix set negative size,"""fix set negative size for pool\r\n""",https://github.com/panjf2000/ants/pull/117,imxyb,github:GithubAccount:1:7411249,,117,2020-10-18T14:58:12.000+00:00,,2020-10-19T01:58:45.000+00:00,,,55d7f5eb6298d59b76a26b56d1bbb776503a8563,hotfix-poolsize,master,94a7a7f1cb3a11fcaaf9608c94fe1dc0bcd98ab0,05a3664dbf966f1a7ced274aaf47d34e644287ef,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,275, |
| github:GithubPullRequest:1:543900177,github:GithubRepo:1:134018330,github:GithubRepo:1:323540538,CLOSED,Add go1.15.x support on CI,"""Add go1.15.x support on CI""",https://github.com/panjf2000/ants/pull/131,kaiiak,github:GithubAccount:1:2832687,,131,2020-12-22T06:25:18.000+00:00,,2021-03-19T02:15:23.000+00:00,,,545d5f0c007d1d5e2cd23ae2d9074365c0f03790,patch-1,master,fd8d670fd09489e6ea7693c0a382ba85d2694f16,15cb2705734c62544ac5dca0de3f28f03a69a854,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,276, |
| github:GithubPullRequest:1:582870188,github:GithubRepo:1:134018330,github:GithubRepo:1:343711920,CLOSED,Change the writing of if...err,"""---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [x] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/136,Comolli,github:GithubAccount:1:47921612,,136,2021-03-02T09:24:36.000+00:00,,2021-03-11T02:27:15.000+00:00,,,ed97c442167956de4aa11495a37f2557edebd904,master,master,fd8d670fd09489e6ea7693c0a382ba85d2694f16,5431f73492ade2e5b947a98f6032595c32cf730e,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,277, |
| github:GithubPullRequest:1:586207150,github:GithubRepo:1:134018330,github:GithubRepo:1:345288213,CLOSED,The program should return directly when the pool size passed in when …,"""…calling the NewPool interface is less than or equal to 0\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: 'code improve'\r\n---\r\n""",https://github.com/panjf2000/ants/pull/139,zhangyuanxue,github:GithubAccount:1:32893410,,139,2021-03-07T08:00:46.000+00:00,,2021-03-12T12:45:57.000+00:00,,,9a4288b9368ab4551d967fddda163d6be2182fde,feature/zhangyuanxue/dev,master,fd8d670fd09489e6ea7693c0a382ba85d2694f16,ba4160c5fd41151ebbd50cb786c5ce21711b5a7b,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,278, |
| github:GithubPullRequest:1:607755003,github:GithubRepo:1:134018330,github:GithubRepo:1:353622545,CLOSED,pool_list,"""sequence""",https://github.com/panjf2000/ants/pull/149,yddeng,github:GithubAccount:1:41562937,,149,2021-04-02T01:16:21.000+00:00,,2021-04-02T04:09:52.000+00:00,,,fd1b0378ee9b60fe32a2fe5c8198a427e5f46949,pool_list,master,dbcb6a104f23b1a6a7521796b30515230353283e,674fe08bb2c2ced275600ebdddf2412c84e2c349,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,279, |
| github:GithubPullRequest:1:654684379,github:GithubRepo:1:134018330,github:GithubRepo:1:371305210,OPEN,Submit a task with args to pool,"""---\r\nname: Resolve problem with args capturing\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\nNew feature.\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\nSometimes, we need to call go-routines with args, but by default we have problem - wrong args capturing. And pool has the same problem. This PR resolves this problem.\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [x] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/158,icecube092,github:GithubAccount:1:58211133,,158,2021-05-27T08:53:42.000+00:00,,,,,077334b198b9af2322e214675bb4fcb62b0a7c0c,args_capture,master,134f354e8e3ba73a35bc7da671ea6d1a8001d35d,2dd731d5897d50508e9d262cf64a8f4807f0f42f,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,280, |
| github:GithubPullRequest:1:669972849,github:GithubRepo:1:134018330,github:GithubRepo:1:376993065,OPEN,allow NewPoolWithFunc can invoke with nil argument,"""2. abstract a Task interface for SubmitTask which is more convenient\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: 'allow NewPoolWithFunc can invoke with nil argument'\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\noptimizations\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\n1. allow NewPoolWithFunc can invoke with nil argument\r\n2. abstract a Task interface for SubmitTask which is more convenient\r\n\r\n## 3. Please link to the relevant issues (if any).\r\nnone\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n\r\nnone\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/167,bingoohuang,github:GithubAccount:1:1940588,,167,2021-06-15T00:57:34.000+00:00,,,,,eb924ade19ae94cc8f85cab39a71f6afa56fdef3,master,master,134f354e8e3ba73a35bc7da671ea6d1a8001d35d,9915f61140287a2f768fcaf71f6d5bd6454521c9,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,281, |
| github:GithubPullRequest:1:686947632,github:GithubRepo:1:134018330,github:GithubRepo:1:384510398,MERGED,Timing issue in the TestNonblockingSubmitWithFunc,"""On some machines this unit would fail due to a timing issue. Since the Invoke in the loop was using nil as the param, it would (depending on timing) lead to the workers finishing the (w *goWorkerWithFunc) run() in the range loop over w.args as args would == nil and return. \r\n\r\nIf an explicit time.Sleep(1 * time.Second) is added before the \""\tassert.EqualError(t, p.Invoke(nil), ErrPoolOverload.Error(),\"" it is easily reproducible.\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\nbug-fix\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\nstated above\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\nn/a\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\nn/a\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [x] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/172,jdamick,github:GithubAccount:1:12317,,172,2021-07-09T17:43:56.000+00:00,2021-07-12T14:52:47.000+00:00,2021-07-12T14:52:47.000+00:00,,,63489606efd8498bdd76c375b2913e7decaa1e63,patch-1,master,4b16a811165326723182488f21b22ea6761418f4,57eb78708675c067aeadad224f0ce57a53edc248,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,282, |
| github:GithubPullRequest:1:693963625,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Fix CI workflow to make the cache action really work,"""workflows add cache mod file\r\nworkflows should be restore cache before unit test\r\nlink [actions/cache](https://github.com/marketplace/actions/cache)\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: 'workflows'\r\nlabels: 'workflows'\r\nassignees: ''\r\n---\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n fix workflows\r\n## 2. Please describe how these code changes achieve your intention.\r\n no\r\n## 3. Please link to the relevant issues (if any).\r\n no\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n no\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [x] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/174,thinkgos,github:GithubAccount:1:49174849,,174,2021-07-21T00:56:19.000+00:00,2021-07-21T03:21:49.000+00:00,2021-07-21T03:21:49.000+00:00,,,cfb27797a83ff7ea787acf1c6627657ac174dca3,master,master,63489606efd8498bdd76c375b2913e7decaa1e63,1a658c033be78d2dea8db57c166ee4ba3ad951f7,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,283, |
| github:GithubPullRequest:1:696437287,github:GithubRepo:1:134018330,github:GithubRepo:1:389252738,OPEN,feat: goroutine exits immediately,"""---\r\nname: goroutine exits immediately\r\nabout: goroutine exits immediately, lazy init defaultAntsPool\r\ntitle: 'goroutine exits immediately'\r\nlabels: ''\r\nassignees: 'panjf2000'\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\noptimizations\r\n\r\nFirst of all, thanks to ants for maintaining a good pool implementation. In the process of using it, it was found that some goroutines did not exit when Release was called. This mr change will cause all goroutines to exit immediately.\r\nExcept for the first time, the global defaultAntsPool will be created by default. In this mr, defaultAntsPool will be created the first time it is called.\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\nTODO\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\nTODO\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\nTODO\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [x] I have documented feature info on the README (only when this PR is adding a new feature).\r\n""",https://github.com/panjf2000/ants/pull/176,exfly,github:GithubAccount:1:22613193,,176,2021-07-25T03:44:37.000+00:00,,,,,caecc9821c7f6f304bd2325bcb200b69f0489210,feat-goroutine-exits-immediately,master,134f354e8e3ba73a35bc7da671ea6d1a8001d35d,12dd0eaff299e7425062bab820801494355e025b,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,284, |
| github:GithubPullRequest:1:731946063,github:GithubRepo:1:134018330,github:GithubRepo:1:398834222,MERGED,style: fixed some typos in the comments,"""---\r\nname: Pull request\r\nabout: typos in comments\r\ntitle: fixed some typos in the comments\r\nlabels: \r\nassignees: @panjf2000 \r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\nfixed some typos only for comments\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\nfixed some typos only for comments\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\nno issues related\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\nno need for docs change\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/184,automano,github:GithubAccount:1:17286982,,184,2021-09-11T15:06:25.000+00:00,2021-09-13T03:57:25.000+00:00,2021-09-13T03:57:25.000+00:00,,,f62e8ab1e0a951ab278ac794979b27ebd89ab0b5,master,master,6de43fdfb9f358a7552f05d0989710dd89380236,2201960d862462743cc1c9da0ca0911d905f25d3,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,285, |
| github:GithubPullRequest:1:736936308,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Update the link of one of the relevant articles,"""Hello! I never got the chance to mention it before, but thank you for linking one of my articles in your repository :) \r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\nNo\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\nI'm working on migrating my domain from `twinnation.org` to `twin.sh`, thus I'm preemptively updating the link to prevent it from becoming dead at some point\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\nN/A\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\nN/A\r\n\r\n\r\n## 5. Checklist\r\n\r\n- [X] I have squashed all insignificant commits.\r\n- [X] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [X] I have written unit tests and verified that all tests passes (if needed).\r\n- [X] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [X] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/185,TwiN,github:GithubAccount:1:15699766,,185,2021-09-18T17:06:03.000+00:00,2021-09-19T02:56:40.000+00:00,2021-09-19T02:56:40.000+00:00,,,61d120b6f086998184f402a83ace485a036d4c7d,patch-1,master,f62e8ab1e0a951ab278ac794979b27ebd89ab0b5,71fd3a37d0df59cf1e73fa1272ecd92bab11a7c1,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,286, |
| github:GithubPullRequest:1:742901118,github:GithubRepo:1:134018330,github:GithubRepo:1:0,MERGED,Update the link of one of the relevant articles,"""re: #185\r\n\r\nMissed the `README_ZH.md` file 😅 """,https://github.com/panjf2000/ants/pull/186,TwiN,github:GithubAccount:1:15699766,,186,2021-09-26T15:53:39.000+00:00,2021-09-27T02:38:55.000+00:00,2021-09-27T02:38:55.000+00:00,,,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,patch-1,master,61d120b6f086998184f402a83ace485a036d4c7d,41f6b572b25da6363d7d7c45b77705fd8bee7466,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,287, |
| github:GithubPullRequest:1:757412327,github:GithubRepo:1:134018330,github:GithubRepo:1:416596451,MERGED,add shopify into user cases,"""Fixes https://github.com/panjf2000/ants/issues/188""",https://github.com/panjf2000/ants/pull/189,lilien1010,github:GithubAccount:1:3814966,,189,2021-10-13T13:34:05.000+00:00,2021-10-13T13:42:42.000+00:00,2021-10-13T13:42:42.000+00:00,,,76ce0ce24f21b1dd13050e0c84b07ce55e68f111,add-shopify-as-user-case,master,3f9c4cd54898e7149c7f6d072213b8fdbd0036d8,efe0bad6c0ab13b54d00909864e34a1060e41d6e,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,288, |
| github:GithubPullRequest:1:763816683,github:GithubRepo:1:134018330,github:GithubRepo:1:419934243,CLOSED,add more test about spinlock,"""---\r\nname: Pull request\r\nabout: add more test about spinlock\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n just add more test about spinlock\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n \r\nSimulate the performance comparison of spinlock with and without backoff and mutex in different scenarios\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\nFixes #191 \r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] I (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/192,liu-song,github:GithubAccount:1:22676124,,192,2021-10-22T02:53:44.000+00:00,,2021-11-27T13:44:28.000+00:00,,,74520b109f893c8e4a85e6a4b8cad96dcddc8d94,master,master,d3e3a334a3b1a5b80e75b296ebd84fe89f5edec0,d16a241d2624bf815159acf091d6f62e663af999,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,289, |
| github:GithubPullRequest:1:770998086,github:GithubRepo:1:134018330,github:GithubRepo:1:423301234,CLOSED,Replace goto with simple for loop,"""---\r\nname: Pull request\r\nabout: Replace goto with simple for loop\r\ntitle: 'Replace goto with simple for loop'\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\noptimizations\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\nReplace goto with simple for loop\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\nnone\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\nnone\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [x] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/193,lord63,github:GithubAccount:1:5268051,,193,2021-11-02T00:36:11.000+00:00,,2021-11-18T14:44:40.000+00:00,,,46126780142e06608ca4c49572160365f8f92282,drop-goto-usage-with-for,master,76ce0ce24f21b1dd13050e0c84b07ce55e68f111,676e5c84e4da504bb4577e1af0b37b7c82cc52ad,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,290, |
| github:GithubPullRequest:1:791490205,github:GithubRepo:1:134018330,github:GithubRepo:1:0,CLOSED,optimize: calculating mid in binary search,"""---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: ''\r\nlabels: ''\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\nOptimization.\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\nTo avoid calculating mid overflow, see [stackoverflow](https://stackoverflow.com/questions/6735259/calculating-mid-in-binary-search) discussion.\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [ ] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [ ] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [ ] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/198,qmdx00,github:GithubAccount:1:27898261,,198,2021-11-30T09:34:02.000+00:00,,2021-12-01T00:42:16.000+00:00,,,0a67f19748a39459ab7b84e0bb89d9314e751433,optimize-calculating-mid,master,1e897421860606afc3d1304cafe5cd187cee13e9,c038cb6a3fdb41292378e91098b5badff5adb8f4,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,291, |
| github:GithubPullRequest:1:816835878,github:GithubRepo:1:134018330,github:GithubRepo:1:445578800,MERGED,Add binarysearch of loop queue,"""---\r\nname: Pull request\r\nabout: Add binarysearch method to loop_queue to get expired workers, just like worker_stack.\r\ntitle: ''\r\nlabels: ''\r\nassignees: 'bright2227'\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\noptimizations \r\n\r\n\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\nI found that loop_queue had an intention to use binarysearch method, just like worker_stack. But it's removed before being merged into the master branch due to some bugs. I mapped true positions to imaginary positions before using binarysearch method and also add some tests to make sure it works.\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\nhttps://github.com/panjf2000/ants/pull/53#pullrequestreview-299506068\r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\nNo need.\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [ ] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/206,bright2227,github:GithubAccount:1:64823610,,206,2022-01-08T10:06:36.000+00:00,2022-01-31T02:49:03.000+00:00,2022-01-31T02:49:03.000+00:00,,,1bd4304727b2ea62ec243f3145389d6ffe3607cf,add_binarysearch_of_loop_q,master,1e897421860606afc3d1304cafe5cd187cee13e9,1b95a084ac08cd34e247b5d3d0063778cfc14748,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,292, |
| github:GithubPullRequest:1:835038436,github:GithubRepo:1:134018330,github:GithubRepo:1:449536867,MERGED,Awake the blocking callers when Tune(size int) is invoked to expand the pool,"""…capacity\r\n\r\n---\r\nname: Pull request\r\nabout: Propose changes to the code\r\ntitle: 'Instantly scale up capacity when using Tune(size int) to enlarge the capacity'\r\nlabels: 'enhancement'\r\nassignees: ''\r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\nWhen using Tune(size int) to enlarge the capacity, create a worker immediately to perform blocking tasks.\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\n\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\nclose #205 \r\n\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\n\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [ ] I have documented feature info on the README (only when this PR is adding a new feature).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n""",https://github.com/panjf2000/ants/pull/210,codingfanlt,github:GithubAccount:1:35493957,,210,2022-01-29T08:01:24.000+00:00,2022-02-14T13:51:40.000+00:00,2022-02-14T13:51:41.000+00:00,,,fbd17036dbf5ae677ba9e41326745a65e655232f,feat/instantly-scale-up-capacity,master,0fa2fd6dc1811f81026a252854f4a8c0471ac7b0,0e17530397bcec737dd9a77fc9589a6866ec4f6e,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,293, |
| github:GithubPullRequest:1:842184289,github:GithubRepo:1:134018330,github:GithubRepo:1:456662951,OPEN,Remove worker_func.go and modify pool_func.go simplifying the library,"""---\r\nname: Remove worker_func.go and modify pool_func.go simplifying the library\r\nabout: Remove worker_func.go and modify pool_func.go to simply utilize the non-func pool+worker implementation\r\ntitle: 'Remove worker_func.go and modify pool_func.go simplifying the library'\r\nlabels: ''\r\nassignees: @panjf2000 \r\n---\r\n\r\n<!--\r\nThank you for contributing to `ants`! Please fill this out to help us make the most of your pull request.\r\n\r\nWas this change discussed in an issue first? That can help save time in case the change is not a good fit for the project. Not all pull requests get merged.\r\n\r\nIt is not uncommon for pull requests to go through several, iterative reviews. Please be patient with us! Every reviewer is a volunteer, and each has their own style.\r\n-->\r\n\r\n## 1. Are you opening this pull request for bug-fixs, optimizations or new feature?\r\n\r\nSimplifying the library\r\n\r\n## 2. Please describe how these code changes achieve your intention.\r\n<!-- Please be specific. Motivate the problem, and justify why this is the best solution. -->\r\n\r\nWhile reading through the library it became clear to me that `PoolWithFunc` was just a specific case of `Pool`, where instead of submitting tasks, the caller simply passes arguments for a pre-defined function to be run on the workers. This means that, instead of a `chan func() interface{}` as the message queue, we use a `chan interface{}`, and IMO this shouldn't warrant a completely different `Pool` implementation.\r\n\r\nThis PR proposes the complete removal of the `worker_func.go` file, choosing instead to adapt `PoolWithFunc` to use the default `Pool`, changing `.Invoke` to simply call the underlying `Pool.Submit` method with an anonymous function wrapping `p.poolFunc(args)`, transforming it into a `goWorker` accepted task, giving us a more robust and simpler library.\r\n\r\n## 3. Please link to the relevant issues (if any).\r\n<!-- This adds crucial context to your change. -->\r\n\r\n## 4. Which documentation changes (if any) need to be made/updated because of this PR?\r\n<!-- Reviewers will often reference this first in order to know what to expect from the change. Please be specific enough so that they can paste your wording into the documentation directly. -->\r\n\r\nNo documentation changes are needed as this doesn't change any of API or examples used.\r\n\r\n## 4. Checklist\r\n\r\n- [x] I have squashed all insignificant commits.\r\n- [x] I have commented my code for explaining package types, values, functions, and non-obvious lines.\r\n- [x] I have written unit tests and verified that all tests passes (if needed).\r\n- [x] (optional) I am willing to help maintain this change if there are issues with it later.\r\n- ~I have documented feature info on the README (only when this PR is adding a new feature).~\r\n""",https://github.com/panjf2000/ants/pull/211,lucafmarques,github:GithubAccount:1:15234973,,211,2022-02-07T21:31:30.000+00:00,,,,,abc622e2696d0f5c1521c96dd206fc2a25c45ad4,simpler-pool-func,master,134f354e8e3ba73a35bc7da671ea6d1a8001d35d,863116682b4378fc82f00c950e5c6469c0e295bb,"{""ConnectionId"":1,""Name"":""panjf2000/ants""}",_raw_github_api_pull_requests,294, |
