Welcome and thank you for your interest in contributing to Apache Brooklyn! This guide will take you through the process of making contributions to the Apache Brooklyn code base.
Apache Brooklyn is licensed under the Apache License, Version 2.0. All contributions will be under this license, so please read and understand this license before contributing.
For all but the most trivial patches, you are required to file a Contributor License Agreement with the Apache Software Foundation. Please read the guide to CLAs to find out how to file a CLA with the Foundation.
If it‘s your first contribution or it’s a particularly big or complex contribution, things typically go much more smoothly when they start off with a conversation. Visit our Community page to see how you can contact us via IRC or email.
Your first step is to create or find an issue in Brooklyn's Jira for your feature request or fix. For small changes this isn‘t necessary, but it’s good to see if your change fixes an existing issue anyway.
This is our preferred way for contributing code. Our GitHub repository is located at https://github.com/apache/incubator-brooklyn
Your commit messages must properly describes the changes that have been made and their purpose (here are some guidelines). If your contributions fix a Jira issue, then ensure that you reference the issue (like BROOKLYN-9876) in the commit message.
Create a pull request (PR) in GitHub for the change you're interested in making. The comment section of the PR must contain a link to the Jira issue (if it has one).
Some good references for working with GitHub are below. We ask that you keep your change rebased to master as much as possible, and we will ask you to rebase again if master has moved before accepting your patch.
Finally, add a comment in the Jira issue with a link to the pull request so we know the code is ready to be reviewed.
The Apache Brooklyn community will review your pull request before it is merged. This process can take a while, so please be patient. If we are slow to respond, please feel free to post a reminder to the PR, Jira issue, IRC channel or mailing list - see the Community page to see how to contact us.
During the review process you may be asked to make some changes to your submission. While working through feedback, it can be beneficial to create new commits so the incremental change is obvious. This can also lead to a complex set of commits, and having an atomic change per commit is preferred in the end. Use your best judgement and work with your reviewer as to when you should revise a commit or create a new one.
A pull request is considered ready to be merged once it gets at lease one +1 from a committer. Once all the changes have been completed and the pull request is accepted, you may be asked to rebase it against the latest code. You may also wish to squash some commits together and make other history revisions, to leave the commit history clean and easily understood.
If you prefer to not use GitHub, then that is fine - we are also happy to accept patches attached to a Jira issue. Our canonical repository is located at https://git-wip-us.apache.org/repos/asf/incubator-brooklyn.git; for example:
$ git clone https://git-wip-us.apache.org/repos/asf/incubator-brooklyn.git
When producing patches, please use git format-patch or a similar mechanism - this will ensure that you are properly attributed as the author of the patch when a committer merges it.