Google Git
Sign in
apache / impala / refs/heads/3.x
commitc4c6bd398639753bc339f5ece3136db7b67c41fb[log] [tgz]
authorstiga-huang <huangquanlong@gmail.com>Tue Jul 19 11:16:11 2022 +0800
committerQuanlong Huang <huangquanlong@gmail.com>Tue Jul 19 11:00:05 2022 +0000
tree33d39562fc2b0afe41eb69c18d207dbb2cf95379
parent1de16355eea1ab3f6eb93472dbfa40cd37de39a4 [diff]
IMPALA-11444: Fix wrong results when reading wide rows from ORC

After IMPALA-9228, ORC scanner reads rows into scratch batch where we
perform conjuncts and runtime filters. The survived rows will be picked
by the output row batch. We loop this until the output row batch is
filled (1024 rows by default) or we finish reading the ORC batch (1024
rows by default).

Usually the loop will have only 1 iteration since the scratch batch
capacity is also 1024. All rows of the current ORC batch can be
materialized into the scratch batch. However, when reading wide rows
that have tuple size larger than 4096 bytes, the scratch batch capacity
will be reduced to be lower 1024, i.e. the scratch batch can store less
than 1024 rows. In this case, we need more iterations in the loop.

The bug is that we didn't commit rows to the output row batch after each
iteration. The suvived rows will be ovewritten in the second iteration.

This is fixed in a later optimization (IMPALA-9469) which is missing in
the 3.x branch. This patch only pick the fix of it.

Tests:
 - Add test on wide tables with 2K columns

Change-Id: I09f1c23c817ad012587355c16f37f42d5fb41bff
Reviewed-on: http://gerrit.cloudera.org:8080/18745
Reviewed-by: Gabor Kaszab <gaborkaszab@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
2 files changed
tree: 33d39562fc2b0afe41eb69c18d207dbb2cf95379
  1. be/
  2. bin/
  3. cmake_modules/
  4. common/
  5. docker/
  6. docs/
  7. ext-data-source/
  8. fe/
  9. impala-parent/
  10. infra/
  11. lib/
  12. query-event-hook-api/
  13. security/
  14. shaded-deps/
  15. shell/
  16. ssh_keys/
  17. testdata/
  18. tests/
  19. www/
  20. .clang-format
  21. .clang-tidy
  22. .gitattributes
  23. .gitignore
  24. buildall.sh
  25. CMakeLists.txt
  26. EXPORT_CONTROL.md
  27. LICENSE.txt
  28. LOGS.md
  29. NOTICE.txt
  30. README.md
  31. setup.cfg
README.md

Welcome to Impala

Lightning-fast, distributed SQL queries for petabytes of data stored in Apache Hadoop clusters.

Impala is a modern, massively-distributed, massively-parallel, C++ query engine that lets you analyze, transform and combine data from a variety of data sources:

  • Best of breed performance and scalability.
  • Support for data stored in HDFS, Apache HBase and Amazon S3.
  • Wide analytic SQL support, including window functions and subqueries.
  • On-the-fly code generation using LLVM to generate CPU-efficient code tailored specifically to each individual query.
  • Support for the most commonly-used Hadoop file formats, including the Apache Parquet project.
  • Apache-licensed, 100% open source.

More about Impala

To learn more about Impala as a business user, or to try Impala live or in a VM, please visit the Impala homepage.

If you are interested in contributing to Impala as a developer, or learning more about Impala's internals and architecture, visit the Impala wiki.

Supported Platforms

Impala only supports Linux at the moment.

Export Control Notice

This distribution uses cryptographic software and may be subject to export controls. Please refer to EXPORT_CONTROL.md for more information.

Build Instructions

See bin/bootstrap_build.sh.

Detailed Build Notes

Impala can be built with pre-built components or components downloaded from S3. The components needed to build Impala are Apache Hadoop, Hive, HBase, and Sentry. If you need to manually override the locations or versions of these components, you can do so through the environment variables and scripts listed below.

Scripts and directories
LocationPurpose
bin/impala-config.shThis script must be sourced to setup all environment variables properly to allow other scripts to work
bin/impala-config-local.shA script can be created in this location to set local overrides for any environment variables
bin/impala-config-branch.shA version of the above that can be checked into a branch for convenience.
bin/bootstrap_build.shA helper script to bootstrap some of the build requirements.
bin/bootstrap_development.shA helper script to bootstrap a developer environment. Please read it before using.
be/build/Impala build output goes here.
be/generated-sources/Thrift and other generated source will be found here.
Build Related Variables
Environment variableDefault valueDescription
IMPALA_HOMETop level Impala directory
IMPALA_TOOLCHAIN“${IMPALA_HOME}/toolchain”Native toolchain directory (for compilers, libraries, etc.)
SKIP_TOOLCHAIN_BOOTSTRAP“false”Skips downloading the toolchain any python dependencies if “true”
CDH_BUILD_NUMBERIdentifier to indicate the CDH build number
CDH_COMPONENTS_HOME“${IMPALA_HOME}/toolchain/cdh_components-${CDH_BUILD_NUMBER}”Location of the CDH components within the toolchain.
CDH_MAJOR_VERSION“5”Identifier used to uniqueify paths for potentially incompatible component builds.
IMPALA_CONFIG_SOURCED“1”Set by ${IMPALA_HOME}/bin/impala-config.sh (internal use)
JAVA_HOME“/usr/lib/jvm/${JAVA_VERSION}”Used to locate Java
JAVA_VERSION“java-7-oracle-amd64”Can override to set a local Java version.
JAVA“${JAVA_HOME}/bin/java”Java binary location.
CLASSPATHSee bin/set-classpath.sh for details.
PYTHONPATHWill be changed to include: “${IMPALA_HOME}/shell/gen-py” “${IMPALA_HOME}/testdata” “${THRIFT_HOME}/python/lib/python2.7/site-packages” “${HIVE_HOME}/lib/py” “${IMPALA_HOME}/shell/ext-py/prettytable-0.7.1/dist/prettytable-0.7.1” "${IMPALA_HOME}/shell/ext-py/sasl-0.1.1/dist/sasl-0.1.1-py2.7-linux-x "${IMPALA_HOME}/shell/ext-py/sqlparse-0.1.19/dist/sqlparse-0.1.19-py2
Source Directories for Impala
Environment variableDefault valueDescription
IMPALA_BE_DIR“${IMPALA_HOME}/be”Backend directory. Build output is also stored here.
IMPALA_FE_DIR“${IMPALA_HOME}/fe”Frontend directory
IMPALA_COMMON_DIR“${IMPALA_HOME}/common”Common code (thrift, function registry)
Various Compilation Settings
Environment variableDefault valueDescription
IMPALA_BUILD_THREADS“8” or set to number of processors by default.Used for make -j and distcc -j settings.
IMPALA_MAKE_FLAGS""Any extra settings to pass to make. Also used when copying udfs / udas into HDFS.
USE_SYSTEM_GCC“0”If set to any other value, directs cmake to not set GCC_ROOT, CMAKE_C_COMPILER, CMAKE_CXX_COMPILER, as well as setting TOOLCHAIN_LINK_FLAGS
IMPALA_CXX_COMPILER“default”Used by cmake (cmake_modules/toolchain and clang_toolchain.cmake) to select gcc / clang
USE_GOLD_LINKER“true”Directs backend cmake to use gold.
IS_OSX“false”(Experimental) currently only used to disable Kudu.
Dependencies
Environment variableDefault valueDescription
HADOOP_HOME“${CDH_COMPONENTS_HOME}/hadoop-${IMPALA_HADOOP_VERSION}/”Used to locate Hadoop
HADOOP_INCLUDE_DIR“${HADOOP_HOME}/include”For ‘hdfs.h’
HADOOP_LIB_DIR“${HADOOP_HOME}/lib”For ‘libhdfs.a’ or ‘libhdfs.so’
HIVE_HOME“${CDH_COMPONENTS_HOME}/{hive-${IMPALA_HIVE_VERSION}/”
HBASE_HOME“${CDH_COMPONENTS_HOME}/hbase-${IMPALA_HBASE_VERSION}/”
SENTRY_HOME“${CDH_COMPONENTS_HOME}/sentry-${IMPALA_SENTRY_VERSION}/”Used to setup test data
THRIFT_HOME“${IMPALA_TOOLCHAIN}/thrift-${IMPALA_THRIFT_VERSION}”