commit | f7dbd4939903b1dbb1994423f24a2f4159daf48a | [log] [tgz] |
---|---|---|
author | Sahil Takiar <takiar.sahil@gmail.com> | Thu Sep 03 19:13:33 2020 -0700 |
committer | Impala Public Jenkins <impala-public-jenkins@cloudera.com> | Thu Sep 10 20:37:05 2020 +0000 |
tree | 928e5553767079357dcaee632516bc082df45037 | |
parent | 673111be7d48a1f383e553e24bf6a027e41f91a3 [diff] |
IMPALA-9740, IMPALA-9403: Fix remaining custom cluster TSAN errors This patch fixes the remaining TSAN errors reported while running custom cluster tests. After this patch, TSAN can be enabled for custom cluster tests (currently it is only run for be tests). Adds a data race suppression for HdfsColumnarScanner::ProcessScratchBatchCodegenOrInterpret, which usually calls a codegen function. TSAN currently does not support codegen functions, so this warning needs to be suppressed. The call stack of this warning is: #0 kudu::BlockBloomFilter::Find(unsigned int) const kudu/util/block_bloom_filter.cc:257:7 #1 <null> <null> (0x7f19af1c74cd) #2 impala::HdfsColumnarScanner::ProcessScratchBatchCodegenOrInterpret(impala::RowBatch*) exec/hdfs-columnar-scanner.cc:106:10 #3 impala::HdfsColumnarScanner::TransferScratchTuples(impala::RowBatch*) exec/hdfs-columnar-scanner.cc:66:34 Fixes a data race in DmlExecState::FinalizeHdfsInsert where a local HdfsFsCache::HdfsFsMap is unsafely passed between threads of a HdfsOperationSet. HdfsOperationSet instances are run in a HdfsOpThreadPool and each operation is run in one of the threads from the pool. Each operation uses HdfsFsCache::GetConnection to get a hdfsFs instance. GetConnection can take in a 'local_cache' of hdfsFs instances before using the global map. The race condition is that the same local cache is used for all operations in HdfsOperationSet. Testing: * Re-ran TSAN tests and confirmed the data races have disappeared Change-Id: If1658a9b56d220e2cfd1f8b958604edcdf7757f4 Reviewed-on: http://gerrit.cloudera.org:8080/16426 Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Lightning-fast, distributed SQL queries for petabytes of data stored in Apache Hadoop clusters.
Impala is a modern, massively-distributed, massively-parallel, C++ query engine that lets you analyze, transform and combine data from a variety of data sources:
To learn more about Impala as a business user, or to try Impala live or in a VM, please visit the Impala homepage. Detailed documentation for administrators and users is available at Apache Impala documentation.
If you are interested in contributing to Impala as a developer, or learning more about Impala's internals and architecture, visit the Impala wiki.
Impala only supports Linux at the moment.
This distribution uses cryptographic software and may be subject to export controls. Please refer to EXPORT_CONTROL.md for more information.
See Impala's developer documentation to get started.
Detailed build notes has some detailed information on the project layout and build.