Google Git
Sign in
apache / impala / ab6c9467f6347671b971dbce4c640bea032b6ed9
commitab6c9467f6347671b971dbce4c640bea032b6ed9[log] [tgz]
authorstiga-huang <huangquanlong@gmail.com>Mon Feb 26 15:59:31 2024 +0800
committerImpala Public Jenkins <impala-public-jenkins@cloudera.com>Tue Mar 12 12:06:40 2024 +0000
treefff2e68525c5bc9ec386035695a27decc64c8205
parent70c35425d3f8ac68b23fb8e0d08e12ee763965d7 [diff]
IMPALA-12831: Fix HdfsTable.toMinimalTCatalogObject() failed by concurrent modification

HdfsTable.toMinimalTCatalogObject() is not always invoked with holding
the table lock, e.g. in invalidating a table, we could replace an
HdfsTable instance with an IncompleteTable instance. We then invoke
HdfsTable.toMinimalTCatalogObject() to get the removed catalog object.
However, the HdfsTable instance could be modified in the meantime by a
concurrent DDL/DML that would reload it, e.g. a REFRESH statement. This
causes HdfsTable.toMinimalTCatalogObject() failed by
ConcurrentModificationException on the column/partition list.

This patch fixes the issue by try acquiring the table read lock in
HdfsTable.toMinimalTCatalogObject(). If it fails, the partition ids and
names won't be returned. Also updates the method to not collecting the
column list since it's unused.

Tests
 - Added e2e test
 - Ran CORE tests

Change-Id: Ie9f8e65c0bd24000241eedf8ca765c1e4e14fdb3
Reviewed-on: http://gerrit.cloudera.org:8080/21072
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
3 files changed
tree: fff2e68525c5bc9ec386035695a27decc64c8205
  1. .devcontainer/
  2. be/
  3. bin/
  4. cmake_modules/
  5. common/
  6. docker/
  7. docs/
  8. fe/
  9. infra/
  10. java/
  11. lib/
  12. package/
  13. security/
  14. shell/
  15. ssh_keys/
  16. testdata/
  17. tests/
  18. www/
  19. .clang-format
  20. .clang-tidy
  21. .gitattributes
  22. .gitignore
  23. buildall.sh
  24. CMakeLists.txt
  25. EXPORT_CONTROL.md
  26. LICENSE.txt
  27. LOGS.md
  28. NOTICE.txt
  29. README-build.md
  30. README.md
  31. setup.cfg
README.md

Welcome to Impala

Lightning-fast, distributed SQL queries for petabytes of data stored in open data and table formats.

Impala is a modern, massively-distributed, massively-parallel, C++ query engine that lets you analyze, transform and combine data from a variety of data sources:

More about Impala

The fastest way to try out Impala is a quickstart Docker container. You can try out running queries and processing data sets in Impala on a single machine without installing dependencies. It can automatically load test data sets into Apache Kudu and Apache Parquet formats and you can start playing around with Apache Impala SQL within minutes.

To learn more about Impala as a user or administrator, or to try Impala, please visit the Impala homepage. Detailed documentation for administrators and users is available at Apache Impala documentation.

If you are interested in contributing to Impala as a developer, or learning more about Impala's internals and architecture, visit the Impala wiki.

Supported Platforms

Impala only supports Linux at the moment. Impala supports x86_64 and has experimental support for arm64 (as of Impala 4.0). Impala Requirements contains more detailed information on the minimum CPU requirements.

Supported OS Distributions

Impala runs on Linux systems only. The supported distros are

  • Ubuntu 16.04/18.04
  • CentOS/RHEL 7/8

Other systems, e.g. SLES12, may also be supported but are not tested by the community.

Export Control Notice

This distribution uses cryptographic software and may be subject to export controls. Please refer to EXPORT_CONTROL.md for more information.

Build Instructions

See Impala's developer documentation to get started.

Detailed build notes has some detailed information on the project layout and build.