commit 8afce97c521f16f3775b396077382138a2932768
author skyyws <skyyws@163.com> Sat Dec 28 12:28:21 2019 +0000
committer Impala Public Jenkins <impala-public-jenkins@cloudera.com> Mon Dec 30 06:31:26 2019 +0000
tree 36f12aea576c228ed2ffcc7c089e41711629369a
parent fa7d91fd305bac2dc5c4a145528b6cc45f5972fe

IMPALA-9266: Fix test_log_fragments.py test case failed after add
CreateKuduTableWithoutHMSTest.java

After add CreateKuduTableWithoutHMSTest.java in IMPALA-8974,
test_log_fragments.py test case failed while running exhaustive test in
jenkins. The main reason is CreateKuduTableWithoutHMSTest test case
restart the impala cluster without --log_dir. The solution is add start
parameter '--log_dir' to restart impala cluster.

Change-Id: I2cbe4dc25a9e748e8c29d71ff8f968bb2faab914
Reviewed-on: http://gerrit.cloudera.org:8080/14957
Reviewed-by: Quanlong Huang <huangquanlong@gmail.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>

fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java

diff --git a/fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java b/fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
index ae60a5c..2d1b522 100644
--- a/fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
+++ b/fe/src/test/java/org/apache/impala/catalog/CreateKuduTableWithoutHMSTest.java
@@ -82,10 +82,10 @@
    */
   private static void restartImpalaCluster(boolean useHiveMetastore)
       throws IOException, InterruptedException {
-    String args = "";
+    StringBuilder args = new StringBuilder(" --log_dir=${IMPALA_EE_TEST_LOGS_DIR}");
     String kuduVariant = "";
     if (!useHiveMetastore) {
-      args = " --env_vars=CUSTOM_CLASSPATH=" + TMP_HIVE_SITE;
+      args.append(" --env_vars=CUSTOM_CLASSPATH=" + TMP_HIVE_SITE);
       kuduVariant = "KUDU_VARIANT=without_hms_config";
     }
 
@@ -95,7 +95,7 @@
 
     String generateCmd = String.format("bash %s/bin/create-test-configuration.sh",
                                        IMPALA_HOME);
-    String restartCmd = IMPALA_HOME + "/bin/start-impala-cluster.py" + args;
+    String restartCmd = IMPALA_HOME + "/bin/start-impala-cluster.py" + args.toString();
     String cmdStr = generateCmd + " && " + restartCmd;
     Process p = Runtime.getRuntime().exec(getCmdsArray(cmdStr), envpArray);
     p.waitFor();