tree e1158ed92a83f0f59e502874823ebff485f84193
parent 179b14876d13353302d075be13f0ed1145041bfa
author xqhe <hexianqing312@126.com> 1598245974 +0800
committer Impala Public Jenkins <impala-public-jenkins@cloudera.com> 1600782186 +0000

IMPALA-10096: Use the original ordinal if the group by ordinal reference is a constant int

The SelectStmt's groupingExprs_ uses the analyzed version and the
ordinal reference will be substituted.
It will throw an exception if the ordinal reference is still a numeric
literal, because we will re-analyze after the expression has been
rewritten. For example, here "count(1)" is rewritten to "count(*)" so
we need to re-analyze the new query.
select 13, id, count(1) from dimtbl group by 1, 2;
The rewritten sql should be
select 13, id, count(*) from dimtbl group by 1, id;
If the original query uses "count(*)", it won't hit the bug since
no rewriting happens.

Testing:
 - Added new unit tests with ordinal in GROUP BY whereas SELECT has
   the INT literal.
 - Ran 'mvn test' for the FE

Change-Id: I34f659d15073d69aa0a4685f56ad94557df86560
Reviewed-on: http://gerrit.cloudera.org:8080/16353
Reviewed-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>