tree ed61b9d7e7cbab769b714b5f23d0f638e4eba4a0
parent 28d94851b1418ddd57e4c046646f7a2df0e702d7
author Vihang Karajgaonkar <vihangk1@apache.org> 1598383346 -0700
committer Vihang Karajgaonkar <vihang@cloudera.com> 1598461723 +0000

IMPALA-4364: [Addendum] Compare specific fields in StorageDescriptor

The query option REFRESH_UPDATED_HMS_PARTITIONS was introduced
earlier in IMPALA-4364 to detect changes in the partition
objects in HMS when a refresh table command is issued. Originally,
it relied on using the StorageDescriptor#equals() method to
determine if the Partition in catalogd is same as partition
in HMS with while executing the refresh statement.

However, using StorageDescriptor#equals() is dependent on HMS
version and may introduce inconsistent behaviors after upgrades.
For example, when we backported the original patch to older
distribution which uses Hive-2, the SkewedInfo field of
StorageDescriptor is not null. This field causes the comparison
logic to fail, since catalogd doesn't store the SkewedInfo
field in the cached StorageDescriptor to optimize memory usage.

This patch modifies the comparison logic to use explicit
implementation in HdfsPartition class which compares only
some fields which are cached in the HdfsPartition object.

Testing:
1. Added a new test for the comparison method.
2. Modified existing test for the query option.

Change-Id: I90c797060265f8f508d0b150e15da3d0f9961b9b
Reviewed-on: http://gerrit.cloudera.org:8080/16363
Tested-by: Impala Public Jenkins <impala-public-jenkins@cloudera.com>
Reviewed-by: Vihang Karajgaonkar <vihang@cloudera.com>