tree f8cd88dbd49e74f32dc3fa9e4513e49b5da3e948
parent 81a7f6d30d03e47093b28c50628631eb5a281c60
author Stamatis Zampetakis <zabetak@gmail.com> 1707212477 +0100
committer Stamatis Zampetakis <zabetak@gmail.com> 1709200078 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 iQIzBAABCgAdFiEEBHSVd/2TRnS5zUXF13wzg/GSdXAFAmXgUs4ACgkQ13wzg/GS
 dXDlWw//YJe3ncn3h6ZkGUq7wpSELkJwUZBOMAw60lpMTfDxQlFU6qSYDld+aist
 LsAdva1mNT0BndNA2fjjZFE1sCuZQ9i07wTbwDivsk1popKFn4cpx6kb6XXPKgrn
 uNKtLQFLphk2NtBdy1jyHL0tqX0oJE53YXolUHiSwTE0BDc1snSZqoLQ6/W0r3Mo
 Zgf+IlZyWtaahQt8aYB42qT8me+QOosVHRep63SCgsdb/ze+4H/ANknaglY8wthY
 6OxNx1kgIb7tm2la/V08zxJlLKNmyV6PFmGmpzBkDxMt+P65jyEIQ0sMwwzWAyZj
 d8HikIz5NtIcL/xNM0wwq/VORBpU6SbGDZgPI/wWVBfLRrR/0pIinfBDa+rH8WGd
 vfOC3J47omyCX0bjGxN1jxQP+rfQqJFM48K5qLuj5o6+8tWNudZuFEt/cdtyWXtE
 Y5QvtmAE32x2fIy0pzlqqgwpQttig72K+/Zm2NNn7vJvvu2scdUUVJ8GSkz7NEEN
 LhUPTH+kQ2RJCWrhOESfLiyamH5/reNJtSslwwfAy4VCtlQQoFv0W0AHXUoDMBIt
 ZhiyeBeyIcdSPeKiYHD7o2cFIMoKYTurODxEuFk+o2nrIIbwrbi5IFHgPoZHbwC5
 zV5Zosi0yxm8yQgSdBXHAMBHeXpb517tCGscT4PwWiYKWWwphNE=
 =dr43
 -----END PGP SIGNATURE-----

HIVE-28063: Drop PerfLogger#setPerfLogger method and unused fields/methods (Stamatis Zampetakis reviewed by Laszlo Bodor, Attila Turoczy)

The PerfLogger#setPerfLogger is redundant and error-prone.

The small number of current uses could be replaced by simply calling the respective getter (which implicitly changes the underlying ThreadLocal variable).

Ideally thread local variable should never be set after obtaining the initial value. Moreover, allowing any caller to change the thread local variable can affect the correctness of the program.

Dropping this method improves the encapsulation and readability of the class.

The org.apache.hadoop.hive.metastore.metrics.PerfLogger has various unused fields/methods that can be removed as well to improve encapsulation, readability, and maintenance.

Close apache/hive#5066