Add concurrent control to DistClusterControllerStateModel._controller access to avoid NPE. (#1753)

This PR fixes a potential NPE Exception that may be thrown in the DistClusterControllerStateModel state transition methods.
When this error happens, a follower-to-leader state transition might be interrupted. The controller instance partition will be set with the ERROR state but the controller instance may have connected to the Zookeeper already. This causes inconsistency and leakage since the controller instance won't be properly cleaned up when it is dropped directly from the ERROR state.
2 files changed
tree: 3de5cd28e6959efbbb2bd9f737ff2c5ccf028413
  1. .github/
  2. helix-admin-webapp/
  3. helix-agent/
  4. helix-common/
  5. helix-core/
  6. helix-front/
  7. helix-lock/
  8. helix-rest/
  9. metadata-store-directory-common/
  10. metrics-common/
  11. recipes/
  12. scripts/
  13. website/
  14. zookeeper-api/
  15. .gitignore
  16. build
  17. bump-up.command
  18. deploySite.sh
  19. helix-style-intellij.xml
  20. helix-style.xml
  21. hpost-review.sh
  22. LICENSE
  23. NOTICE
  24. pom.xml
  25. README.md
README.md

Apache Helix

Github Build Maven Central License codecov.io

Helix Logo

Helix is part of the Apache Software Foundation.

Project page: http://helix.apache.org/

Mailing list: http://helix.apache.org/mail-lists.html

Build

mvn clean install -Dmaven.test.skip.exec=true

WHAT IS HELIX

Helix is a generic cluster management framework used for automatic management of partitioned, replicated and distributed resources hosted on a cluster of nodes. Helix provides the following features:

  1. Automatic assignment of resource/partition to nodes
  2. Node failure detection and recovery
  3. Dynamic addition of Resources
  4. Dynamic addition of nodes to the cluster
  5. Pluggable distributed state machine to manage the state of a resource via state transitions
  6. Automatic load balancing and throttling of transitions