)]}'
{
  "commit": "2f8f236014c202250db178ad4a64f25dd79f371b",
  "tree": "9b13bb0791ddf137f3ee650da7ba9eee5b2305eb",
  "parents": [
    "a1bbe1dbbd1100c18a8d3729d39664f99589f5ad"
  ],
  "author": {
    "name": "Nicolas Spiegelberg",
    "email": "nspiegelberg@apache.org",
    "time": "Tue Oct 11 19:13:34 2011 +0000"
  },
  "committer": {
    "name": "Nicolas Spiegelberg",
    "email": "nspiegelberg@apache.org",
    "time": "Tue Oct 11 19:13:34 2011 +0000"
  },
  "message": "Fixing TestRemoteTable and TestHRegionServerFileSystemFailure broken by D336813\n\nSummary:\nIn D336813 I broke two unit tests, which was hard to notice because they failed\nwith time-outs. TestHRegionServerFileSystemFailure re-starts a master in the end\nif it had crashed so that regionservers can shut down properly, but the\ncondition it uses to identify whether the master is still alive was no longer\nvalid, because there is now a thread object wrapping HMaster, and\nmaster.isAlive() is meaningless. I replaced this with master.isClosed() and\nremoved hard-coded master class from the unit test.\n\nTestRemoteTable started failing because of a bug in JVMClusterUtil.shutdown()\n-- it did not call join() on master threads.\n\nAlso calling Thread.currentThread().interrupt() when handling\nInterruptedException instead of simply ignoring it. This is recommended by Java\nConcurrency in Practice as well as in other articles online as the proper way to\nhandle InterruptedException, but I must admit I don\u0027t fully understand why.\n\nTest Plan: All 621 unit tests pass (compared to 614 without the patch).\n\nReviewers: pritam, kranganathan, pkhemani\n\nReviewed By: pritam\n\nCC: hbase-eng@lists, pkhemani, pritam, mbautin\n\nDifferential Revision: 340934\n\nRevert Plan: OK\n\ngit-svn-id: https://svn.apache.org/repos/asf/hbase/branches/0.89@1182040 13f79535-47bb-0310-9956-ffa450edef68\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "ffacfbd8f867c7e6a2e27cc55eabfb9de487097a",
      "old_mode": 33188,
      "old_path": "src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java",
      "new_id": "843dafc16fe16633f4d2128392f362feb833c276",
      "new_mode": 33188,
      "new_path": "src/main/java/org/apache/hadoop/hbase/util/JVMClusterUtil.java"
    },
    {
      "type": "modify",
      "old_id": "f3e040346d8c1321c9f5ee45bb7cb457d12b05fa",
      "old_mode": 33188,
      "old_path": "src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java",
      "new_id": "442e185ee9a0397589f10db521573f8ea149204b",
      "new_mode": 33188,
      "new_path": "src/test/java/org/apache/hadoop/hbase/MiniHBaseCluster.java"
    },
    {
      "type": "modify",
      "old_id": "f7449e454434a32181d330af07a5b8fa1547f0f8",
      "old_mode": 33188,
      "old_path": "src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerFileSystemFailure.java",
      "new_id": "a96e507ca10d1cbffb2e536a9b9af28a2e59f3a7",
      "new_mode": 33188,
      "new_path": "src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionServerFileSystemFailure.java"
    }
  ]
}