blob: afe53ccefe2514a8c6c722c2a4f8e3566567c1cf [file] [log] [blame]
<?xml version="1.0" encoding="UTF-8"?>
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
<document xmlns=""
<title>Generating Patches</title>
<section name="Generating patches" id="Generatingpatches">
<p>Follow these steps to generate a patch that can be attached to a JIRA issue for review.</p>
<li>Check out the Giraph source from the <a href="">git repository</a>.</li>
<li>Make the changes necessary for your particular issue while following the code conventions found in <tt>CODE_CONVENTIONS</tt>. Try to avoid unnecessary changes, such as extra whitespace or formatting changes. Include a unit test, or be ready to justify in the JIRA why one isn't necessary.</li>
<li>Verify the new and existing tests continue to pass via <tt>mvn clean verify</tt>. This maven lifecycle will do checkstyle, findbugs, license checks (Apache Rat), and unittests. Verify the change works as expected on a real cluster, if possible. If one's not available for testing, mention it on the JIRA so another contributor can verify.</li>
<li>Generate a patch with <tt>git diff --no-prefix trunk > GIRAPH-{ISSUE_NUMBER}.patch</tt> (the <tt>--no-prefix</tt> option is necessary to make the patch compatible with Apache's subversion repository). For subsequent patches, if necessary, number each version to make it easier for reviewers to track their progress.</li>
<li>Attach the patch to the JIRA issue (click <em>More Actions</em> and then <em>Attach File</em> from the top menu) using the comment to briefly explain what changes it contains and what testing was done. Mark the JIRA as <em>Patch Available</em> to let reviewers know it's ripe for evaluation.</li>
<li>Optionally, you can open <a href="">reviewboard</a> request for the patch, although not all reviewers use this tool.</li>
<p>A committer should review the patch shortly and either provide feedback for a new version, or commit it to the Giraph source.</p>