| commit | 669ffd174e40f9ce7a8ee9f71752bff43d38b457 | [log] [tgz] |
|---|---|---|
| author | Romain Manni-Bucau <rmannibucau@gmail.com> | Sat Apr 11 11:11:44 2020 +0200 |
| committer | Romain Manni-Bucau <rmannibucau@gmail.com> | Sat Apr 11 11:11:44 2020 +0200 |
| tree | c3adb10b32d041aee4f1866eda9fec81bfc6fc38 | |
| parent | 55d1cb28620acb2c1a83aa982d2ce10f35ed53c2 [diff] |
simpletimer returns previous minute representation and timer handles zero values
diff --git a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/SimpleTimerImpl.java b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/SimpleTimerImpl.java index 5945762..f3df332 100644 --- a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/SimpleTimerImpl.java +++ b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/SimpleTimerImpl.java
@@ -108,13 +108,13 @@ @Override public Duration getMaxTimeDuration() { maybeRotate(); - return max; + return previousMax; } @Override public Duration getMinTimeDuration() { maybeRotate(); - return min; + return previousMin; } private void maybeRotate() {
diff --git a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/TimerImpl.java b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/TimerImpl.java index 6067b09..bd546f4 100644 --- a/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/TimerImpl.java +++ b/geronimo-metrics-common/src/main/java/org/apache/geronimo/microprofile/metrics/common/TimerImpl.java
@@ -40,7 +40,7 @@ @Override public void update(final Duration duration) { - if (duration.isNegative() || duration.isZero()) { + if (duration.isNegative()) { return; } histogram.update(duration.toNanos());