)]}' { "commit": "82f5df25df2603e2f5fefb82ea890edac9a98f15", "tree": "4e846bbce9eef89cabb4677cb8adef915405e1b9", "parents": [ "f4a0c52bb7c8457e61857be349d0443e68d1f4fa" ], "author": { "name": "Dale Emery", "email": "demery@vmware.com", "time": "Wed Dec 16 12:04:17 2020 -0800" }, "committer": { "name": "GitHub", "email": "noreply@github.com", "time": "Wed Dec 16 12:04:17 2020 -0800" }, "message": "GEODE-6622: WAN rolling upgrade test bind exception (#5854)\n\nBefore: Several WAN rolling upgrade tests allocated ports for two\r\nlocators by making two separate calls to AvailablePort. AvailablePort\r\nrandomly samples ports with replacement, and so two calls can return the\r\nsame port if the port is not put into use between the calls. From time\r\nto time, a test would get the same port for both locators, and the second\r\nwould fail to start because its port was already in use.\r\n\r\nNow: The tests allocate both ports at the same time, ensuring that the\r\ntwo ports differ. And they get their ports from AvailablePortHelper,\r\nwhich allocates ports round robin instead of sampling with replacement,\r\nfurther reducing the chance of collisions.", "tree_diff": [ { "type": "modify", "old_id": "c948414b7771434abd43e3bd6cac94ab0d6a2d42", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.java", "new_id": "2e688070063a383c6ef1585933ce35d10fe4cd3e", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeCreateGatewaySenderMixedSiteOneCurrentSiteTwo.java" }, { "type": "modify", "old_id": "8bdbc3e105c804489e8a0eb72faa01277824c01b", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeEventProcessingMixedSiteOneCurrentSiteTwo.java", "new_id": "952917fed04879e357e24de0a4a6f31bf73e68f6", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeEventProcessingMixedSiteOneCurrentSiteTwo.java" }, { "type": "modify", "old_id": "7796ead6a3f6bd042fa2680d77b5dfcb75686bce", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeEventProcessingOldSiteOneCurrentSiteTwo.java", "new_id": "200c65be1c2cede421de8ca7ae5ce8f8dac78b77", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeEventProcessingOldSiteOneCurrentSiteTwo.java" }, { "type": "modify", "old_id": "130656dc28ae2ac73d887be8244fa116761427ab", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeMultipleReceiversDefinedInClusterConfiguration.java", "new_id": "6d08cea6e23dbb01c7efbfcfe2e467265d43d010", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeMultipleReceiversDefinedInClusterConfiguration.java" }, { "type": "modify", "old_id": "39d1f831f2c33160b9481c1cd5dcf8733b294d9a", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeSecondaryEventsNotReprocessedAfterCurrentSiteMemberFailover.java", "new_id": "4a880c815c1ed8638c0e430745e11abfd818911f", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeSecondaryEventsNotReprocessedAfterCurrentSiteMemberFailover.java" }, { "type": "modify", "old_id": "4350148a9a3bcc3f7bf47a4499a798b6e3cb87a3", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover.java", "new_id": "f25397806a1d4ec77ba4fbde343c0b7fbc39d670", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeSecondaryEventsNotReprocessedAfterOldSiteMemberFailover.java" }, { "type": "modify", "old_id": "d60ec4518cea527368c798d4828280fbaadbb1a0", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeVerifyGatewayReceiverDoesNotSendRemoveCacheServerProfileToMembersOlderThan1dot5.java", "new_id": "432d7f632ea324725b72bbba6dbce513f2ae7c52", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeVerifyGatewayReceiverDoesNotSendRemoveCacheServerProfileToMembersOlderThan1dot5.java" }, { "type": "modify", "old_id": "1fdb9e65c6e2a4b3a3813c029a35fcf81a112006", "old_mode": 33188, "old_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeVerifyGatewaySenderProfile.java", "new_id": "8d70ec729c79f21411f1c703b6c907311818a44a", "new_mode": 33188, "new_path": "geode-wan/src/upgradeTest/java/org/apache/geode/cache/wan/WANRollingUpgradeVerifyGatewaySenderProfile.java" } ] }