tree 86201bf708e9cd0a405ed826533939c941697783
parent a9d346f6581cd2861a9f9870574a441c9c439d36
author Bill Burcham <bill.burcham@gmail.com> 1604014705 -0700
committer GitHub <noreply@github.com> 1604014705 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJfm1JxCRBK7hj4Ov3rIwAAdHIIAEjUi3BeOIevL5/ReROh9zXj
 9UDFACfFNZOD0VNoS5DoF5+T5XDGJWX9EzHoB7sqZsJRD2kcJ/tA2006DIVb2NH9
 TmjE1Q4cbu4I6GfPoZ4qP5zNj5SlRCs0kyRzsJ9E1kWBgQ/X4xFTqvbItRJZ1pdD
 mgCUUiiIZvnoHaupEi3wrbf6vhO9UiXy17OR/rFr3TdztXZ6O+8f9F4mDHn4CbIr
 vUvTzNYSoN67afPoCs4nMpuG5caKp52sN8Gnq/tktF3cxCtpfkBipMyOVKDILaSh
 xizM34zkqZTtQooBkjdFVcb+oRwgRP5IwNOvBojf6NbxADVskeBIDvhyHCAzF0U=
 =ADSL
 -----END PGP SIGNATURE-----
 

GEODE-8652: NioSslEngine.close() Bypasses Locks (#5666)

- NioSslEngine.close() proceeds even if readers (or writers) are
  operating on its ByteBuffers, allowing Connection.close() to close 
  its socket and proceed.

- NioSslEngine.close() needed a lock only on the output buffer, so 
  we split what was a single lock into two. Also instead of using 
  synchronized we use a ReentrantLock so we can 
  call tryLock() and time out if needed in NioSslEngine.close().

- Since readers/writers may hold locks on these input/output buffers
  when NioSslEngine.close() is called a reference count is maintained
  and the buffers are returned to the pool only when the last user
  is done.

- To manage the locking and reference counting a new AutoCloseable
  ByteBufferSharing interface is introduced with a trivial 
  implementation: ByteBufferSharingNoOp and a real implementation:
  ByteBufferSharingImpl.

Co-authored-by: Bill Burcham <bill.burcham@gmail.com>
Co-authored-by: Darrel Schneider <dschneider@pivotal.io>
Co-authored-by: Ernie Burghardt <burghardte@vmware.com>