tree 823858707a369b386adaca96b9dbcaaa9bebe625
parent 5ca66db1f89e8cd165d20b70bd8ed6c9df66d8b4
author Blake Bender <bbender@pivotal.io> 1562436061 -0700
committer GitHub <noreply@github.com> 1562436061 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJdIOHdCRBK7hj4Ov3rIwAAdHIIAAnpfjdLiVBAw3da7j7PxMIw
 cMLwckVaLlQPxqzZqK9zkb3/+ddeKP8vPSEZtAFPQe4Qp4+P3pypU26EZmNFouGp
 hCP2mebIsjCkuKhhZD1tvhYIQUCr8dX/T+I6o/ZHciJ2SlwppmLZi/RijMq4bwcg
 2vbciMHpyVPhVcW17GlBl7osteGKrMPjxYtr4aGnaQfgN3GBuBr6rUbpmcnbfJOK
 fKrk9JgrpWePmFjFR5XPO9W0msReQAF4FjDogLlB723wNs0CXyAzoMOpyLdOXnl+
 lphJW3TWAkoZ45jTEvyNo2ZDUwdE1glKM58MYzKIi7e7EkKTC6sbbdCDW3ihQAA=
 =315k
 -----END PGP SIGNATURE-----
 

GEODE 6835 - Remove use of defunct client request

* Remove defunct UPDATE_CLIENT_NOTIFICATION request
- Geode server has no code to handle this message, and hasn't for *several years*
- Sending the message while a security manager is in use will yield an AuthorizationRequiredException and cause the server to close the connection
- Remove commented-out code
- Adapt test framework to add user/password to connect command when using securityManager

* Miscellaneous Refactoring
- Remove gratuitous use of this pointer
- Fix crash at cache closing, and fix casing of m_keepAlive member variable
- Fix format specifier in log statement
- Add a cq test that verifies create/update/destroy notifications
- Fix typo in GF error code name
- Check for null member vars in catch block, to avoid segfault
- Remove TODO comment
- clang-format changes
- Fix casing of method initTcrConnection
- Break out AuthInitialize tests into separate file
- Count calls to AuthInitialize::getCredentials, verify that it's being called
- Test bad credentials on client
- Test with/without subscription enabled on pool (different failure mode)
- Rename GFErrTypeToException: Doesn't actually translate to an exception, but rather throws the exception.  Doesn't always throw an exception, sometimes just does nothing
- Use Cluster object in put + Cq + AuthInitialize test.  Adapt Cluster, Server, Locator classes to take security parameters
- Move SimpleAuthInitialize class into separate file.  Class is used in two different test suites now, maybe more going forward
- Remove unused test functions that were breaking Linux builds

Co-authored-by: Jacob Barrett <jbarrett@pivotal.io>
Co-authored-by: Barry Oglesby <boglesby@pivotal.io>
Co-authored-by: Ivan Godwin <igodwin@pivotal.io>
Co-authored-by: Steve Sienkowski <ssienkowski@pivotal.io>