)]}'
{
  "commit": "47a1b2e10ccb9bcad325b218dc883db062815ad8",
  "tree": "2e8c4dddc02ded73f2fa1dfe493f737dc6bbd9bc",
  "parents": [
    "3f73eb5527530d28dd1d3bd7d04b029247907a9d"
  ],
  "author": {
    "name": "Heracles",
    "email": "2678785492@qq.com",
    "time": "Sat Aug 22 10:32:50 2026 +0800"
  },
  "committer": {
    "name": "GitHub",
    "email": "noreply@github.com",
    "time": "Sat Aug 22 10:32:50 2026 +0800"
  },
  "message": "[ISSUE-796] Clean up PartitionType TODOs in rocksdb store module (#823)\n\n* [ISSUE-796] Clean up PartitionType TODOs in rocksdb store module\n\nThe `PartitionType` enum in the rocksdb store carried two stale `TODO`s:\n\n- `// TODO: Support dt partition` on `DT` — DT partition is already\n  implemented (`SyncGraphDtPartitionProxy`, dispatched by `ProxyBuilder`),\n  so the TODO is removed.\n- `// TODO: Support label dt partition` on `DT_LABEL` — this combination\n  has no proxy implementation. Configuring it previously fell through to a\n  generic \"unexpected partition type\" error. `ProxyBuilder.build` now\n  rejects `DT_LABEL` explicitly with a message that names the unsupported\n  type, and the TODO is replaced with a NOTE documenting the gap.\n\nAdds `PartitionTypeTest` covering the enum lookup/flags, the explicit\n`DT_LABEL` rejection, and that `DT` is still dispatched to a real proxy.\nThe test targets `ProxyBuilder` directly so it does not depend on opening\na native RocksDB instance.\n\nCo-Authored-By: Claude Opus 4.8 \u003cnoreply@anthropic.com\u003e\n\n* [ISSUE-796] Address review: fail fast on DT_LABEL before opening RocksDB\n\n- Extract ProxyBuilder.checkPartitionTypeSupported and call it in\n  StaticGraphRocksdbStoreBase.init before super.init() opens the RocksDB\n  instance, so an unsupported partition.type fails fast without leaving a\n  half-initialized store on disk.\n- Rewrite the DT-dispatch test to mock RocksdbClient/encoder and assert the\n  returned proxy is a SyncGraphDtPartitionProxy, instead of inferring dispatch\n  from an incidental NullPointerException.\n\nCo-Authored-By: Claude Opus 4.8 \u003cnoreply@anthropic.com\u003e\n\n---------\n\nCo-authored-by: Claude Opus 4.8 \u003cnoreply@anthropic.com\u003e",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "b652e1d533ca18d67b9a03889a8d2ac1a4f29990",
      "old_mode": 33188,
      "old_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/pom.xml",
      "new_id": "7b7835684b3442f8cb9311b933ecdc22cd0f90c6",
      "new_mode": 33188,
      "new_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/pom.xml"
    },
    {
      "type": "modify",
      "old_id": "5c71cee93fa696adcb241d9bf175d6dc283ae63f",
      "old_mode": 33188,
      "old_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/src/main/java/org/apache/geaflow/store/rocksdb/PartitionType.java",
      "new_id": "4f77042bc197ea213e3ac8104af9d056967ef1bd",
      "new_mode": 33188,
      "new_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/src/main/java/org/apache/geaflow/store/rocksdb/PartitionType.java"
    },
    {
      "type": "modify",
      "old_id": "81bffca8019ce127b42ad6846660abe958eacaac",
      "old_mode": 33188,
      "old_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/src/main/java/org/apache/geaflow/store/rocksdb/StaticGraphRocksdbStoreBase.java",
      "new_id": "6359c62d0417500880d3fc284042eb5d99665e8d",
      "new_mode": 33188,
      "new_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/src/main/java/org/apache/geaflow/store/rocksdb/StaticGraphRocksdbStoreBase.java"
    },
    {
      "type": "modify",
      "old_id": "0f7e786ab36d9f8610d35afbddc4c9352e74c4a8",
      "old_mode": 33188,
      "old_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/src/main/java/org/apache/geaflow/store/rocksdb/proxy/ProxyBuilder.java",
      "new_id": "216c70d7c41cad9169f24a42503b2a157fa8afd4",
      "new_mode": 33188,
      "new_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/src/main/java/org/apache/geaflow/store/rocksdb/proxy/ProxyBuilder.java"
    },
    {
      "type": "add",
      "old_id": "0000000000000000000000000000000000000000",
      "old_mode": 0,
      "old_path": "/dev/null",
      "new_id": "a2ab06b0c0dc791fd479e93929807e30975db668",
      "new_mode": 33188,
      "new_path": "geaflow/geaflow-plugins/geaflow-store/geaflow-store-rocksdb/src/test/java/org/apache/geaflow/store/rocksdb/PartitionTypeTest.java"
    }
  ]
}