tree 7f265ca91be9745f9a36ecc01a929bff4ddcc6cd
parent 5fb2fb634ea856cc0cd4034dc9bc99e4a58219d5
author Mihai Chira <mihaic@apache.org> 1502877065 +0200
committer Mihai Chira <mihaic@apache.org> 1502877065 +0200

FLEX-18746 CAUSE: HierarchicalCollectionView.updateLength() was ignoring nodes without children, as it should. However, the function it called for the nodes with children, getChildren() unfortunately had a necessary side-effect (which is a poor design choice, to be sure), which was to add an event listener to the children collection. So the empty collections of nodes were not listened to, which meant that once the node was open any children that were added to that node were not counted towards the length of the collection. And one way this inconsistency surfaced was through the expandItem() fatal.

SOLUTION: The best - and most time-consuming - solution to this is to find a way to extract the side-effect of getChildren() into a separate function and call it when needed. However, for the moment I have opted to simply allow getChildren() to be called even for empty nodes, which in turn adds the event listeners.

NOTES: all unit tests now pass.