Keep ordinary sunburst annular labels in their own ring

The review correctly pointed out that the previous r0 guard had been broadened too far. The drilldown view root still needs centered full-circle label placement, but ordinary annular full-circle descendants should keep their midpoint label position.

Constraint: Review noted the removed layout.r0 === 0 guard changed non-view-root annular full-circle sectors
Rejected: Center every full-circle sector | single-child annular descendants would collapse labels to the chart center
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Only root disks and the current sunburst view root should use chart-center full-circle labels
Tested: ./node_modules/.bin/jest --config test/ut/jest.config.cjs test/ut/spec/series/sunburst.test.ts --runInBand --coverage=false; npm run checktype; ./node_modules/.bin/eslint src/chart/sunburst/SunburstPiece.ts test/ut/spec/series/sunburst.test.ts; git diff --check
Not-tested: full visual browser pass
2 files changed
tree: 80949f9c08d99cbe511965fa280e95d46dd9170c
  1. .github/
  2. .husky/
  3. .vscode/
  4. asset/
  5. build/
  6. dist/
  7. extension-src/
  8. i18n/
  9. licenses/
  10. src/
  11. ssr/
  12. test/
  13. theme/
  14. .asf.yaml
  15. .editorconfig
  16. .eslintignore
  17. .eslintrc-common.yaml
  18. .gitattributes
  19. .gitignore
  20. .headerignore
  21. .jshintrc-dist
  22. .lgtm.yml
  23. .npmignore
  24. CONTRIBUTING.md
  25. index.d.ts
  26. KEYS
  27. LICENSE
  28. NOTICE
  29. package-lock.json
  30. package.json
  31. package.README.md
  32. README.md
  33. tsconfig.json
README.md

Apache ECharts

Apache ECharts is a free, powerful charting and visualization library offering easy ways to add intuitive, interactive, and highly customizable charts to your commercial products. It is written in pure JavaScript and based on zrender, which is a whole new lightweight canvas library.

中文官网 | ENGLISH HOMEPAGE

License Latest npm release NPM downloads Contributors

Build Status

Get Apache ECharts

You may choose one of the following methods:

Docs

Get Help

Build

Build echarts source code:

Execute the instructions in the root directory of the echarts: (Node.js is required)

# Install the dependencies from NPM:
npm install

# Rebuild source code immediately in watch mode when changing the source code.
# It opens the `./test` directory, and you may open `-cases.html` to get the list
# of all test cases.
# If you wish to create a test case, run `npm run mktest:help` to learn more.
npm run dev

# Check the correctness of TypeScript code.
npm run checktype

# If intending to build and get all types of the "production" files:
npm run release

Then the “production” files are generated in the dist directory.

Contribution

Please refer to the contributing document if you wish to debug locally or make pull requests.

Resources

Awesome ECharts

https://github.com/ecomfe/awesome-echarts

Extensions

License

ECharts is available under the Apache License V2.

Code of Conduct

Please refer to Apache Code of Conduct.

Paper

Deqing Li, Honghui Mei, Yi Shen, Shuang Su, Wenli Zhang, Junting Wang, Ming Zu, Wei Chen. ECharts: A Declarative Framework for Rapid Construction of Web-based Visualization. Visual Informatics, 2018.