tree a83dcd5cfd5408cdbfc5c6808be542200bdbade7
parent 7139c60868381715273cccb95df68da6bdccdf92
author Gian Merlino <gianmerlino@gmail.com> 1619644422 -0700
committer GitHub <noreply@github.com> 1619644422 -0700
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJgidAGCRBK7hj4Ov3rIwAAFfEIALFLEVwz8onwwN1re/3CLCxB
 sI6cE7kB6d0WjO3U6qSaB6PMj53Ug7EcDXbInkjJixWTjv3lsSIsdwn+4ZYzlAl/
 3bPxq02lq/uzvDN8LNMgvAEIcEw0S7gaoT4ou0DmPBJJojAg7O8e1S0KFPQ36Piw
 ZuMUu2+YK/+xFaZPrvbKSBcPDQFMsJqdFzWheJDdnE5IKsOCdQDP/MhTvuYsvmp/
 oD53aVWJLb8TH9QksBfYUcJQupPuf2E4A1ubB64lk0pZsDvkkVZV9WiobYc8rSHS
 9RuucY5xrdOO+ua/Tn+u8EdX4uwSd/mdwcy8hsgc4BUxdLx7rffbo8DBiTmlIrw=
 =cqxW
 -----END PGP SIGNATURE-----
 

InDimFilter: Fix NPE involving certain Set types. (#11169)

* InDimFilter: Fix NPE involving certain Set types.

Normally, InDimFilters that come from JSON have HashSets for "values".
However, programmatically-generated filters (like the ones from #11068)
may use other set types. Some set types, like TreeSets with natural
ordering, will throw NPE on "contains(null)", which causes the
InDimFilter's ValueMatcher to throw NPE if it encounters a null value.

This patch adds code to detect if the values set can support
contains(null), and if not, wrap that in a null-checking lambda.

Also included:

- Remove unneeded NullHandling.needsEmptyToNull method.
- Update IndexedTableJoinable to generate a TreeSet that does not
  require lambda-wrapping. (This particular TreeSet is how I noticed
  the bug in the first place.)

* Test fixes.

* Improve test coverage