tree 1c9dfe1d1d50a07686109272b0f9dd6afe35d40b
parent 1dabb028430a95c1c56cc034c6df6a24d3ce22f5
author Gian Merlino <gianmerlino@gmail.com> 1713951564 -0700
committer GitHub <noreply@github.com> 1713951564 -0400
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsFcBAABCAAQBQJmKNNMCRC1aQ7uu5UhlAAAuS4QAEDjWvbS0NMxp3dNVgpxAD5h
 VBPIjiKmfrAKAlW9ZZuHHJ8/NdMSV41t4kUUXEOLXFvouBpp0L0+h/d7+T71usrz
 dEc2FyWkvkaOYT3f7zWxr2aJZu41GemsVtmhSUOu79hjgG7dQzy6YpW5S5xakttn
 MkQrAwR5QOiZH2YYu+EEIHlN1Obkx/z/41k3doiYwO5izozTzEwwmLCRhRnbeisY
 +1Spm5tbjrHT1bmuSW30rKixxahBUnfhtWO6i8lFcxnR5geEZPJ3kCo3wIDPbDkc
 TkkVdcz29WT4Iv1n8owmmTutxv7nOr2icYbcXm/mwqxrsHDo0Naf2IvEDgmIzVl7
 CrstjHq2gJn4ZQCCXIEOrYxdKQSuuyIrsg/RzU5DGe5NJjnIe6GwZlkLBYexSZUl
 PedB7+6+HStankO/OoCl2TumiXoHImSK9Ib+M2MozmeK5zcOq9UYGJzYyZ9WtM5E
 aE0m3IkFbGVgIdAldvUhCz7hSbIs7RS5k1yyx9ct2CtGAH4TMfqERXIXQZ2pCCo7
 MKgEYwzjV9AX66qHMzQjGgv3cQxt/2InqONH5qVqlOQYmNFqlvjAIR5pVexrWhg5
 ffGtnPZ1Y/NeVAEJGpZMH/iZBNV6yj/R0B/8Cdp6PJjZ4lGpWaQHOxcWd5UBxhUZ
 0wnNWfJB2VWvw7nmhGYd
 =aL9E
 -----END PGP SIGNATURE-----
 

Reset buffer aggregators when resetting Groupers. (#16296)

Buffer aggregators can contain some cached objects within them, such as
Memory references or HLL Unions. Prior to this patch, various Grouper
implementations were not releasing this state when resetting their own
internal state, which could lead to excessive memory use.

This patch renames AggregatorAdapater#close to "reset", and updates
Grouper implementations to call this reset method whenever they reset
their internal state.

The base method on BufferAggregator and VectorAggregator remains named
"close", for compatibility with existing extensions, but the contract
is adjusted to say that the aggregator may be reused after the method
is called. All existing implementations in core already adhere to this
new contract, except for the ArrayOfDoubles build flavors, which are
updated in this patch to adhere.

Additionally, this patch harmonizes buffer sketch helpers to call their
clear method "clear" rather than a mix of "clear" and "close". (Others
were already using "clear".)