commit d75e553f64ec5f9d6af2fdbd9701399c1013f301
author Christopher Harm <crh5255@psu.edu> Fri Jul 21 16:24:42 2017 -0400
committer Christopher Harm <crh5255@psu.edu> Fri Jul 21 16:24:42 2017 -0400
tree 9c60a89301aa014bbc2475aa37c04951cb5fea16
parent 979421ec8d3c97f849eb0b5681f99a682c94b451

Fixing more UpdateRequestTest assertions and adding a testcase

scim-server/scim-server-common/src/test/java/edu/psu/swe/scim/server/provider/UpdateRequestTest.java

diff --git a/scim-server/scim-server-common/src/test/java/edu/psu/swe/scim/server/provider/UpdateRequestTest.java b/scim-server/scim-server-common/src/test/java/edu/psu/swe/scim/server/provider/UpdateRequestTest.java
index 5591bcf..91feb46 100644
--- a/scim-server/scim-server-common/src/test/java/edu/psu/swe/scim/server/provider/UpdateRequestTest.java
+++ b/scim-server/scim-server-common/src/test/java/edu/psu/swe/scim/server/provider/UpdateRequestTest.java
@@ -198,7 +198,7 @@
    * ArrayList of objects to add.
    */
   @Test
-  public void testAddObjectsToEmptyCollection() throws Exception {
+  public void testAddObjectToEmptyCollection() throws Exception {
     UpdateRequest<ScimUser> updateRequest = new UpdateRequest<>(registry);
 
     ScimUser user1 = createUser1();
@@ -219,6 +219,42 @@
     Assert.assertEquals(Type.ADD, operation.getOperation());
     Assert.assertEquals(PhoneNumber.class, operation.getValue().getClass());
   }
+  
+  @Test
+  public void testAddObjectsToEmptyCollection() throws Exception {
+    UpdateRequest<ScimUser> updateRequest = new UpdateRequest<>(registry);
+
+    ScimUser user1 = createUser1();
+    user1.setPhoneNumbers(new ArrayList<PhoneNumber>());
+    ScimUser user2 = copy(user1);
+    
+    PhoneNumber mobilePhone = new GlobalPhoneNumberBuilder().globalNumber("+1(814)867-5306").build();
+    mobilePhone.setType("mobile");
+    mobilePhone.setPrimary(true);
+    
+    PhoneNumber homePhone = new GlobalPhoneNumberBuilder().globalNumber("+1(814)867-5307").build();
+    homePhone.setType("home");
+    homePhone.setPrimary(true);
+    
+    user2.getPhoneNumbers().add(mobilePhone);
+    user2.getPhoneNumbers().add(homePhone);
+
+    
+    updateRequest.initWithResource("1234", user1, user2);
+    List<PatchOperation> operations = updateRequest.getPatchOperations();
+    Assert.assertNotNull(operations);
+    Assert.assertEquals(2, operations.size());
+    
+    PatchOperation operation = operations.get(0);
+    Assert.assertNotNull(operation.getValue());
+    Assert.assertEquals(Type.ADD, operation.getOperation());
+    Assert.assertEquals(PhoneNumber.class, operation.getValue().getClass());
+    
+    operation = operations.get(1);
+    Assert.assertNotNull(operation.getValue());
+    Assert.assertEquals(Type.ADD, operation.getOperation());
+    Assert.assertEquals(PhoneNumber.class, operation.getValue().getClass());
+  }
 
   @Test
   public void testReplaceSingleAttribute() throws Exception {
@@ -506,7 +542,7 @@
     PatchOperation operation = operations.get(0);
     Assert.assertNotNull(operation.getValue());
     Assert.assertEquals(Type.ADD, operation.getOperation());
-    Assert.assertEquals(ArrayList.class, operation.getValue().getClass());
+    Assert.assertEquals(Photo.class, operation.getValue().getClass());
   }
   
   @Test