tree 0b8bbd357e0e0b5a776624c9739ac99ccf8a376a
parent 08cc0f89fe077234078430bf9b93ebc9dfd70ac5
author Bryan Pendleton <bpendleton@apache.org> 1468022704 +0000
committer Bryan Pendleton <bpendleton@apache.org> 1468022704 +0000

DERBY-6879: Engine deadlock between XA timeout handling and cleanupOnError

This patch was contributed by Brett Bergquist (brett at thebergquistfamily dot com)

The original problem to be solved is that a connection that is performing a
XA transaction that discovers an error that must be cleaned up is going to
have a lock on a EmbedConnection and will then require a lock on the
XATransactionState.

And if the same XA transaction times out (because of the XA transaction
timer value) while the original XA transaction is being worked, then the
timeout handling is going to have a lock on the XATransactionState and then
require a lock on the EmbedConnection, triggering the deadlock.

The change in the patch fixes this problem by altering the locking on
the XATransactionState when invoked via the timeout by removing the
synchronization on the "cancel" method and instead using inline
synchronization on the "XATransactionState" while its internals are being
altered.

Then, it releases the XATransactionState lock to allow the
EmbedConnection.rollback method to be invoked without the lock.

Finally, it acquires the lock again to finish cleaning up the XATransactionState.


git-svn-id: https://svn.apache.org/repos/asf/db/derby/code/trunk@1751977 13f79535-47bb-0310-9956-ffa450edef68