commit fe5f09e035cc9d5d4d3ebc2e6008802b6943e8b4
author Jon Malkin <786705+jmalkin@users.noreply.github.com> Fri Dec 01 20:50:28 2023 -0800
committer Jon Malkin <786705+jmalkin@users.noreply.github.com> Fri Dec 01 20:50:28 2023 -0800
tree 0081e08e6445ac47875cf3a079903e75aa14c4c0
parent c78b692029e84efa78a39a1f31b570c00280a6dc
parent 51e14987edcce1c1d8cd220986918eb592395a78

Merge branch 'ebpps_serialize_fix' of github.com:jmalkin/datasketches-cpp into ebpps_serialize_fix

kll/include/kll_helper_impl.hpp

diff --git a/kll/include/kll_helper_impl.hpp b/kll/include/kll_helper_impl.hpp
index e763c57..bb92bdc 100644
--- a/kll/include/kll_helper_impl.hpp
+++ b/kll/include/kll_helper_impl.hpp
@@ -230,7 +230,8 @@
       // move level over as is
       // make sure we are not moving data upwards
       if (raw_beg < out_levels[current_level]) throw std::logic_error("wrong move");
-      std::move(items + raw_beg, items + raw_lim, items + out_levels[current_level]);
+      if (raw_beg != out_levels[current_level])
+        std::move(items + raw_beg, items + raw_lim, items + out_levels[current_level]);
       out_levels[current_level + 1] = out_levels[current_level] + raw_pop;
     } else {
       // The sketch is too full AND this level is too full, so we compact it
@@ -243,7 +244,8 @@
       const auto half_adj_pop = adj_pop / 2;
 
       if (odd_pop) { // move one guy over
-        items[out_levels[current_level]] = std::move(items[raw_beg]);
+        if (out_levels[current_level] != raw_beg)
+          items[out_levels[current_level]] = std::move(items[raw_beg]);
         out_levels[current_level + 1] = out_levels[current_level] + 1;
       } else { // even number of items
         out_levels[current_level + 1] = out_levels[current_level];