tree 63fb5235b5fc0fc0825a3d8cc60036f79e262313
parent aadcae6b031c31cc48fed45c90b56ef02ac24d5a
author Nick Vatamaniuc <vatamane@apache.org> 1602281444 -0400
committer Nick Vatamaniuc <nickva@users.noreply.github.com> 1602345687 -0400

Properly combine base and extra headers when making replicator requests

Previously we subtly relied on one set of headers being sorted, then sorted the
other set of headers, and ran `lists:ukeymerge/3`. That function, however,
needs both arguments to be sorted in order for it to work as expected. If one
argument wasn't sorted we could get duplicate headers easily, which is what was
observed in testing.

A better fix than just sorting both sets of keys, is to use an actual header
processing library to combine them so we can account for case insensitivity as
well.