| commit | 0d0519729fc5641e6e85cfa7176bb93b8e0e5f9e | [log] [tgz] |
|---|---|---|
| author | ZauberNerd <zaubernerd@zaubernerd.de> | Thu Jun 01 14:21:50 2017 +0200 |
| committer | Steve Gill <stevengill97@gmail.com> | Wed Oct 04 16:01:45 2017 -0700 |
| tree | 707b9fbcd55124b54e179bebe004e55f71f77f4a | |
| parent | ed7b53995d52e61579e8d9fc96ed0a02f4c84dba [diff] |
Fix null-access errors in "addTo/removeFrom*PbxGroup" methods The project exposes a few methods to add/remove children from PbxGroups * `addToPluginsPbxGroup` / `removeFromPluginsPbxGroup` * `addToResourcesPbxGroup` / `removeFromResourcesPbxGroup` * `addToFrameworksPbxGroup` / `removeFromFrameworksPbxGroup` * `addToProductsPbxGroup` / `removeFromProductsPbxGroup` which are used internally in: * `addPluginFile` / `removePluginFile` * `addResourceFile` / `removeResourceFile` * `addProductFile` / `removeProductFile` * `addFramework` / `removeFramework` But neither of these methods do a check whether the `PbxGroup` actually exists before trying to modify it - this can result in a possible null-access error. I ran into this problem when trying to add a framework to a project which didn't have a `Frameworks` `PbxGroup`. This commit adds checks to these methods to test for existence of the `PbxGroup`s and creates them if they don't exist or does an early exit in the case of removal. This closes #3
parser/toolkit for xcodeproj project files
Allows you to edit xcodeproject files and write them back out.
// API is a bit wonky right now
var xcode = require('xcode'),
fs = require('fs'),
projectPath = 'myproject.xcodeproj/project.pbxproj',
myProj = xcode.project(projectPath);
// parsing is async, in a different process
myProj.parse(function (err) {
myProj.addHeaderFile('foo.h');
myProj.addSourceFile('foo.m');
myProj.addFramework('FooKit.framework');
fs.writeFileSync(projectPath, myProj.writeSync());
console.log('new project written');
});
If there's a problem parsing, you will want to edit the grammar under lib/parser/pbxproj.pegjs. You can test it online with the PEGjs online thingy at http://pegjs.majda.cz/online - I have had some mixed results though.
Tests under the test/parser directory will compile the parser from the grammar. Other tests will use the prebuilt parser (lib/parser/pbxproj.js).
To rebuild the parser js file after editing the grammar, run:
./node_modules/.bin/pegjs lib/parser/pbxproj.pegjs
(easier if ./node_modules/.bin is in your path)
Apache V2