tree 1f0ea4754e5787e7f8e2ee1c10bf7f8031e9b9f4
parent 672f7f3eb7003bd9a2f4fb4aca2be05556f6a3e5
author Raphael von der Grün <raphinesse@gmail.com> 1574619240 +0100
committer GitHub <noreply@github.com> 1574619240 +0100
gpgsig -----BEGIN PGP SIGNATURE-----
 
 wsBcBAABCAAQBQJd2shoCRBK7hj4Ov3rIwAAdHIIABNXg3NddquU4eHAwzu1F+Dw
 3d1URCl7TGviwoGMujgAEDuGw89Z3HFcB3UV11CKWPzgrutxTpgtxakryk9a9ov1
 /JeTr9XFGI0ViQzdn0eGg47/qrNIhv8Qyz7rp9S1dfZ5nSw9qlLSf7BQmlcq+aDj
 6K9NYe8IHOChhProwXgJ6C3t2CclpRwTA9A8s6Srazjv5XDRalyL6PiPFtQh5ebI
 5j6AeAXw8re74n767DlSs/OnLUEGReQD0162OclHpoijOobLpqbyR8Q+GM8cBAdT
 AhYtGScYrC8pUT2350qBbTSWmn4TfdAf2vSFximmca1EACUxXGYHSiHqmSPPr78=
 =ehwX
 -----END PGP SIGNATURE-----
 

fix(gitutil): do not stash ignored files (#262)

Until now `gitutil.stashAndPop` ran the following command for each repo:

    git stash save --all --quiet "coho stash"

Beside changed and untracked files, this also stashes ignored files. In
our case that includes the `node_modules` folder. Due to the massive
amount of files in there, that command takes a decent amount of time and
can also lead to _a lot_ of CRLF warning messages, depending on your
local git configuration.

Furthermore, the new build system of `cordova-js` needs to have its
dependencies present to be able to run. But since the `cordova-js` build
is run in a `stashAndPop` block, all modules have been stashed and thus
the build always fails.

AFAICT, no invocation of `gitutil.stashAndPop` does actually _need_ to
stash ignored files. Thus we can resolve these issues by replacing the
`--all` flag with `--include-untracked`, giving us this command:

    git stash save --include-untracked --quiet "coho stash"

This safely stashes all content that could potentially be destroyed by
`coho` operations, while leaving ignored files in place.