commit d71b8c93d20187da61113990f44cb16345cf72cb
author Gary Gregory <garydgregory@gmail.com> Sun Jan 17 09:30:17 2021 -0500
committer Gary Gregory <garydgregory@gmail.com> Sun Jan 17 09:30:17 2021 -0500
tree b52318dd60ce74107e6e1088c3383db3213d4768
parent 57a9a5c14b1bdac50fdf737c63c880a5fb9e106a

Use isEmpty().

Don't nest else clauses needlessly.

src/main/java/org/apache/commons/math4/linear/RealMatrixFormat.java

diff --git a/src/main/java/org/apache/commons/math4/linear/RealMatrixFormat.java b/src/main/java/org/apache/commons/math4/linear/RealMatrixFormat.java
index ff025f8..51ccdc5 100644
--- a/src/main/java/org/apache/commons/math4/linear/RealMatrixFormat.java
+++ b/src/main/java/org/apache/commons/math4/linear/RealMatrixFormat.java
@@ -322,23 +322,21 @@
             if (!rowComponents.isEmpty()) {
                 CompositeFormat.parseAndIgnoreWhitespace(source, pos);
                 if (!CompositeFormat.parseFixedstring(source, trimmedColumnSeparator, pos)) {
-                    if (trimmedRowSuffix.length() != 0 &&
+                    if (!trimmedRowSuffix.isEmpty() &&
                         !CompositeFormat.parseFixedstring(source, trimmedRowSuffix, pos)) {
                         return null;
-                    } else {
-                        CompositeFormat.parseAndIgnoreWhitespace(source, pos);
-                        if (CompositeFormat.parseFixedstring(source, trimmedRowSeparator, pos)) {
-                            matrix.add(rowComponents);
-                            rowComponents = new ArrayList<>();
-                            continue;
-                        } else {
-                            loop = false;
-                        }
                     }
+                    CompositeFormat.parseAndIgnoreWhitespace(source, pos);
+                    if (CompositeFormat.parseFixedstring(source, trimmedRowSeparator, pos)) {
+                        matrix.add(rowComponents);
+                        rowComponents = new ArrayList<>();
+                        continue;
+                    }
+                    loop = false;
                 }
             } else {
                 CompositeFormat.parseAndIgnoreWhitespace(source, pos);
-                if (trimmedRowPrefix.length() != 0 &&
+                if (!trimmedRowPrefix.isEmpty() &&
                     !CompositeFormat.parseFixedstring(source, trimmedRowPrefix, pos)) {
                     return null;
                 }