checkstyle: magic numbers
git-svn-id: https://svn.apache.org/repos/asf/commons/proper/fileupload/trunk@1457003 13f79535-47bb-0310-9956-ffa450edef68
diff --git a/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java b/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
index 912b596..626f415 100644
--- a/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
+++ b/src/main/java/org/apache/commons/fileupload/util/mime/Base64Decoder.java
@@ -25,6 +25,26 @@
final class Base64Decoder {
/**
+ * Bytes per undecoded block.
+ */
+ private static final int BYTES_PER_UNENCODED_BLOCK = 3;
+
+ /**
+ * 2 bits mask.
+ */
+ private static final int MASK_2BITS = 2;
+
+ /**
+ * 4 bits mask.
+ */
+ private static final int MASK_4BITS = 4;
+
+ /**
+ * 6 bits mask.
+ */
+ private static final int MASK_6BITS = 6;
+
+ /**
* Set up the encoding table.
*/
private static final byte[] ENCODING_TABLE = {
@@ -101,7 +121,7 @@
}
int i = off;
- int finish = end - 4;
+ int finish = end - MASK_4BITS;
while (i < finish) {
while ((i < finish) && ignore((char) data[i])) {
@@ -128,40 +148,40 @@
b4 = DECODING_TABLE[data[i++]];
- out.write((b1 << 2) | (b2 >> 4));
- out.write((b2 << 4) | (b3 >> 2));
- out.write((b3 << 6) | b4);
+ out.write((b1 << MASK_2BITS) | (b2 >> MASK_4BITS));
+ out.write((b2 << MASK_4BITS) | (b3 >> MASK_2BITS));
+ out.write((b3 << MASK_6BITS) | b4);
- outLen += 3;
+ outLen += BYTES_PER_UNENCODED_BLOCK;
}
- if (data[end - 2] == PADDING) {
- b1 = DECODING_TABLE[data[end - 4]];
- b2 = DECODING_TABLE[data[end - 3]];
+ if (data[end - MASK_2BITS] == PADDING) {
+ b1 = DECODING_TABLE[data[end - MASK_4BITS]];
+ b2 = DECODING_TABLE[data[end - BYTES_PER_UNENCODED_BLOCK]];
- out.write((b1 << 2) | (b2 >> 4));
+ out.write((b1 << MASK_2BITS) | (b2 >> MASK_4BITS));
outLen += 1;
} else if (data[end - 1] == PADDING) {
- b1 = DECODING_TABLE[data[end - 4]];
- b2 = DECODING_TABLE[data[end - 3]];
- b3 = DECODING_TABLE[data[end - 2]];
+ b1 = DECODING_TABLE[data[end - MASK_4BITS]];
+ b2 = DECODING_TABLE[data[end - BYTES_PER_UNENCODED_BLOCK]];
+ b3 = DECODING_TABLE[data[end - MASK_2BITS]];
- out.write((b1 << 2) | (b2 >> 4));
- out.write((b2 << 4) | (b3 >> 2));
+ out.write((b1 << MASK_2BITS) | (b2 >> MASK_4BITS));
+ out.write((b2 << MASK_4BITS) | (b3 >> MASK_2BITS));
- outLen += 2;
+ outLen += MASK_2BITS;
} else {
- b1 = DECODING_TABLE[data[end - 4]];
- b2 = DECODING_TABLE[data[end - 3]];
- b3 = DECODING_TABLE[data[end - 2]];
+ b1 = DECODING_TABLE[data[end - MASK_4BITS]];
+ b2 = DECODING_TABLE[data[end - BYTES_PER_UNENCODED_BLOCK]];
+ b3 = DECODING_TABLE[data[end - MASK_2BITS]];
b4 = DECODING_TABLE[data[end - 1]];
- out.write((b1 << 2) | (b2 >> 4));
- out.write((b2 << 4) | (b3 >> 2));
- out.write((b3 << 6) | b4);
+ out.write((b1 << MASK_2BITS) | (b2 >> MASK_4BITS));
+ out.write((b2 << MASK_4BITS) | (b3 >> MASK_2BITS));
+ out.write((b3 << MASK_6BITS) | b4);
- outLen += 3;
+ outLen += BYTES_PER_UNENCODED_BLOCK;
}
return outLen;