commit 1ffa799cb3ddf5a4a918e59e46cd9868ee766b19
author Gary D. Gregory <ggregory@apache.org> Wed Sep 19 18:49:37 2018 +0000
committer Gary D. Gregory <ggregory@apache.org> Wed Sep 19 18:49:37 2018 +0000
tree cea0f92a2b6046ce449247bbe31ce1fc43758366
parent e6611eb9fcfef2f26e309cd6e457b866e357a3ca

[DAEMON-392] Undefined behaviour in registry.c dwRegKey = dwRegKey++

git-svn-id: https://svn.apache.org/repos/asf/commons/proper/daemon/trunk@1841363 13f79535-47bb-0310-9956-ffa450edef68

src/changes/changes.xml

diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 2af757d..77ac8f3 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -55,6 +55,9 @@
       <action issue="DAEMON-393" type="fix" dev="ggregory" due-to="Daniel Hofmann">

         Revered code comments for JRE and JDK locations in the registry.

       </action>

+      <action issue="DAEMON-392" type="fix" dev="ggregory" due-to="Daniel Hofmann">

+        Undefined behaviour in registry.c dwRegKey = dwRegKey++

+      </action>

     </release>

     <release version="1.1.0" date="2017-11-15" description="Feature and bug fix release">

       <action issue="DAEMON-368" type="add" dev="ggregory">

src/native/windows/src/registry.c

diff --git a/src/native/windows/src/registry.c b/src/native/windows/src/registry.c
index b96ae44..eb4ed46 100644
--- a/src/native/windows/src/registry.c
+++ b/src/native/windows/src/registry.c
@@ -779,7 +779,7 @@
             lstrcpyW(wsBuf, JRE_REGKEYS[dwRegKey]);
         else
             lstrcpyW(wsBuf, JDK_REGKEYS[dwRegKey]);
-        dwRegKey = dwRegKey++;
+        dwRegKey++;
         dwLen = lstrlenW(wsBuf);
         off = &wsBuf[dwLen];
         dwLen = SIZ_RESMAX;