commit f18828d7d81901452f309b684fcd06ae054e13a0
author Likitha Shetty <Likitha.Shetty@citrix.com> Thu Jan 31 11:52:42 2013 -0800
committer Prachi Damle <prachi@cloud.com> Thu Jan 31 12:00:37 2013 -0800
tree 3ea6d8a0b859da85e3c7f6f59b7b4fd146b72ab4
parent 61f24d8a16450988e37d7f81323042678368ec7b

[EC2 Query API] AttachVolume fails with 'Permission Denied: Invalid Signature' error.

https://reviews.apache.org/r/8480/

In AWSAPI while forming the signature to validate an API, url-encode every parameter name with UTF-8 encoding scheme.

awsapi/src/com/cloud/bridge/service/EC2RestServlet.java

diff --git a/awsapi/src/com/cloud/bridge/service/EC2RestServlet.java b/awsapi/src/com/cloud/bridge/service/EC2RestServlet.java
index 91e08be..78e736f 100644
--- a/awsapi/src/com/cloud/bridge/service/EC2RestServlet.java
+++ b/awsapi/src/com/cloud/bridge/service/EC2RestServlet.java
@@ -1770,8 +1770,8 @@
                     String paramName = (String) params.nextElement();
                     // exclude the signature string obviously. ;)
                     if (paramName.equalsIgnoreCase("Signature")) continue;
-                    if (queryString == null) 
-                        queryString = paramName + "=" + request.getParameter(paramName);
+                    if (queryString == null)
+                        queryString = paramName + "=" + URLEncoder.encode(request.getParameter(paramName), "UTF-8"); 
                     else 
                         queryString = queryString + "&" + paramName + "=" + URLEncoder.encode(request.getParameter(paramName), "UTF-8"); 
                 }